docs: record review-validation lessons and conventions#88
Merged
Conversation
- Add tasks/lessons.md capturing the 0.4.12 review validation failure: - never eslint-disable obsidianmd/* rules - distinguish review error vs warning - use lightweight tags - verify hypotheses with minimal repro before reasoning down a chain - AGENTS.md: codify the obsidianmd disable prohibition and tag convention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Capture the lessons from the 0.4.12 → 0.4.13 release incident so the same mistakes don't recur.
Changes
New
tasks/lessons.md— 4 lessons:eslint-disableanyobsidianmd/*rule (review bot rejects it)error(blocks release) vswarning(noise)AGENTS.md— codify two rules:obsidianmd/*rules; resolve conflicts in codegit tag <version>), not-aContext
0.4.12 failed community review because of an
eslint-disable obsidianmd/ui/sentence-caseadded in #84. 0.4.13 fixed it. These lessons prevent recurrence.