fix: 0.4.13 release validation hotfix#87
Merged
Conversation
The Obsidian community plugin review rejects: - directive comments without a description - disabling obsidianmd/ui/sentence-case (not allowed) Replace the placeholder with a descriptive sentence-case string that needs no suppression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0.4.12 failed Obsidian community plugin review validation. Root cause: the
eslint-disable-next-line obsidianmd/ui/sentence-casecomment added in #84 violates two review rules:obsidianmd/ui/sentence-caseis not allowedThis was NOT caused by the CLI relocation (#85) — bot correctly scanned the new
cli/location; those Node-API findings are warnings, not blockers.Fix
Replace the placeholder
"E.g. excalidraw-plugin"(which triggered sentence-case and needed suppression) with a descriptive"Frontmatter keys to ignore"that needs no rule suppression.Changes
src/settings/settings-tab.ts: drop the eslint-disable comment, use sentence-case placeholder0.4.13Verification