Skip to content

Conversation

@aster94
Copy link
Contributor

@aster94 aster94 commented Jan 24, 2018

@lacklustrlabs
Copy link
Contributor

Why are there .exe and .dll files in there?

@rogerclarkmelbourne
Copy link
Owner

@lacklustrlabs

I agree the exe's etc should not be in the PR.

I had another PR which had some exe's which seemed to have been something to do with the unix permissions

I could not merge that PR either, and had to manually merge the files that really needed to be changed

@aster94
Copy link
Contributor Author

aster94 commented Jan 24, 2018

I must have done some error with git, i am not very proficient with it
Tomorrow i will edit the PR and fix them

@rogerclarkmelbourne
Copy link
Owner

No worries. Git does strange things all the time.

Sometimes I have to rename the whole folder and clone again from the server, and then copy the files which have actually changed, however in this case as you have already pushed back to GitHub, you'd somehow need to get the exe's again and then push again and somehow update the PR (perhaps make a new PR)

You are not the only one who has problems like this ;-)

BTW. If all you did was a global search and replace on all c,cpp and h files for _IO and replace with __IO, I can easily do that in Notepad++ on Windows and perhaps make my own branch for this ??

@aster94
Copy link
Contributor Author

aster94 commented Jan 25, 2018

@rogerclarkmelbourne @lacklustrlabs I am reading only now after removing my guilty files, anyway now this PR doesn't change any .dd and .exe files

P.S: im sure that i didn't modified those files, is it possible that uploading a few sketches with the arduino IDE get them modified?

@stevstrong
Copy link
Collaborator

This does not change F4 files, right?

@aster94
Copy link
Contributor Author

aster94 commented Jan 25, 2018

this does change F1,2,3,4
shouldn't i put them?

@stevstrong
Copy link
Collaborator

stevstrong commented Jan 25, 2018

I cannot see any F4 file in the "Files changed" list.

@stevstrong
Copy link
Collaborator

Ups, sorry, my browser seems to play nuts. I see now all files.

@aster94
Copy link
Contributor Author

aster94 commented Jan 25, 2018

never mind steve!
if someone is wondering why there are 4 lines of difference between the add and delete, this is for "keywords.txt"
+1,256 −1,252 Files changed 118

@victorpv
Copy link
Contributor

victorpv commented Mar 6, 2018

I'm in favor of this PR, will download it and test in the next few days.

@aster94
Copy link
Contributor Author

aster94 commented Mar 8, 2018

thanks @victorpv, i know that there are many reason to don't do this change, on the other hand i am sure it will solve problems in the future
it is like for the wire library, imho it is better to be compliant with the arduino world and in this case also with the compiler

@rogerclarkmelbourne
Copy link
Owner

@victorpv
Did you get around to trying this ?

I'm actually in favor of this, but I know it comes with a lot of risk

@victorpv
Copy link
Contributor

Just tested with the mp3 software in the bluepill RET board. It uses the SDIO port and SPI2/I2S, both with DMA, so does a fair amount of register access. Works fine.
If I get a chance in the next few days will test with the WAV player that uses 2 SPI ports and a timer with DMA.

@rogerclarkmelbourne rogerclarkmelbourne merged commit eede5ab into rogerclarkmelbourne:master Apr 1, 2018
@rogerclarkmelbourne
Copy link
Owner

Thanks
Tested with a fairly complex application using 2 SPI devices and touch screen and also One Pulse timing and it compiled and ran fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants