-
Notifications
You must be signed in to change notification settings - Fork 1.3k
__io is replaced by the more correct __IO #431
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
__io is replaced by the more correct __IO #431
Conversation
|
Why are there .exe and .dll files in there? |
|
I agree the exe's etc should not be in the PR. I had another PR which had some exe's which seemed to have been something to do with the unix permissions I could not merge that PR either, and had to manually merge the files that really needed to be changed |
|
I must have done some error with git, i am not very proficient with it |
|
No worries. Git does strange things all the time. Sometimes I have to rename the whole folder and clone again from the server, and then copy the files which have actually changed, however in this case as you have already pushed back to GitHub, you'd somehow need to get the exe's again and then push again and somehow update the PR (perhaps make a new PR) You are not the only one who has problems like this ;-) BTW. If all you did was a global search and replace on all c,cpp and h files for _IO and replace with __IO, I can easily do that in Notepad++ on Windows and perhaps make my own branch for this ?? |
|
@rogerclarkmelbourne @lacklustrlabs I am reading only now after removing my guilty files, anyway now this PR doesn't change any .dd and .exe files P.S: im sure that i didn't modified those files, is it possible that uploading a few sketches with the arduino IDE get them modified? |
|
This does not change F4 files, right? |
|
this does change F1,2,3,4 |
|
I cannot see any F4 file in the "Files changed" list. |
|
Ups, sorry, my browser seems to play nuts. I see now all files. |
|
never mind steve! |
|
I'm in favor of this PR, will download it and test in the next few days. |
|
thanks @victorpv, i know that there are many reason to don't do this change, on the other hand i am sure it will solve problems in the future |
|
@victorpv I'm actually in favor of this, but I know it comes with a lot of risk |
|
Just tested with the mp3 software in the bluepill RET board. It uses the SDIO port and SPI2/I2S, both with DMA, so does a fair amount of register access. Works fine. |
|
Thanks |
please see:
#422
http://www.stm32duino.com/viewtopic.php?f=2&p=39999#p39999
[i also added some color highlight in keywords.txt]