Skip to content

Commit ed70edb

Browse files
committed
repos: add UploadReleaseAssetFromRelease convenience helper that uses release.UploadURL (fixes google#3849)
1 parent e279f70 commit ed70edb

1 file changed

Lines changed: 56 additions & 0 deletions

File tree

‎github/repos_releases.go‎

Lines changed: 56 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -488,3 +488,59 @@ func (s *RepositoriesService) UploadReleaseAsset(ctx context.Context, owner, rep
488488
}
489489
return asset, resp, nil
490490
}
491+
492+
// UploadReleaseAssetFromRelease uploads an asset using the UploadURL that's embedded
493+
// in a RepositoryRelease object.
494+
//
495+
// This is a convenience wrapper that extracts the release.UploadURL (which is usually
496+
// templated like "https://uploads.github.com/.../assets{?name,label}") and uploads
497+
// the provided file using the existing upload helpers.
498+
//
499+
// GitHub API docs: https://docs.github.com/rest/releases/assets#upload-a-release-asset
500+
//
501+
//meta:operation POST /repos/{owner}/{repo}/releases/{release_id}/assets
502+
func (s *RepositoriesService) UploadReleaseAssetFromRelease(ctx context.Context, release *RepositoryRelease, opts *UploadOptions, file *os.File) (*ReleaseAsset, *Response, error) {
503+
if release == nil || release.UploadURL == nil {
504+
return nil, nil, errors.New("release UploadURL must be provided")
505+
}
506+
if file == nil {
507+
return nil, nil, errors.New("file must be provided")
508+
}
509+
510+
// Extract upload URL and remove template part (e.g. "{?name,label}") if present.
511+
uploadURL := *release.UploadURL
512+
if idx := strings.Index(uploadURL, "{"); idx != -1 {
513+
uploadURL = uploadURL[:idx]
514+
}
515+
516+
// addOptions will append query params for name/label (same as UploadReleaseAsset)
517+
u, err := addOptions(uploadURL, opts)
518+
if err != nil {
519+
return nil, nil, err
520+
}
521+
522+
stat, err := file.Stat()
523+
if err != nil {
524+
return nil, nil, err
525+
}
526+
if stat.IsDir() {
527+
return nil, nil, errors.New("the asset to upload can't be a directory")
528+
}
529+
530+
mediaType := mime.TypeByExtension(filepath.Ext(file.Name()))
531+
if opts != nil && opts.MediaType != "" {
532+
mediaType = opts.MediaType
533+
}
534+
535+
req, err := s.client.NewUploadRequest(u, file, stat.Size(), mediaType)
536+
if err != nil {
537+
return nil, nil, err
538+
}
539+
540+
asset := new(ReleaseAsset)
541+
resp, err := s.client.Do(ctx, req, asset)
542+
if err != nil {
543+
return nil, resp, err
544+
}
545+
return asset, resp, nil
546+
}

0 commit comments

Comments
 (0)