Skip to content

chore(deps-dev): bump @types/node from 25.5.2 to 25.6.0 in /editors/vscode#9

Merged
hugocorreia90 merged 1 commit intomainfrom
dependabot/npm_and_yarn/editors/vscode/types/node-25.6.0
Apr 13, 2026
Merged

chore(deps-dev): bump @types/node from 25.5.2 to 25.6.0 in /editors/vscode#9
hugocorreia90 merged 1 commit intomainfrom
dependabot/npm_and_yarn/editors/vscode/types/node-25.6.0

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 13, 2026

Bumps @types/node from 25.5.2 to 25.6.0.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Apr 13, 2026
@hugocorreia90 hugocorreia90 merged commit f888168 into main Apr 13, 2026
0 of 2 checks passed
@hugocorreia90 hugocorreia90 deleted the dependabot/npm_and_yarn/editors/vscode/types/node-25.6.0 branch April 13, 2026 23:00
hugocorreia90 added a commit that referenced this pull request May 1, 2026
…INSERT (#331)

`detect_drift` previously ignored columns present in the source but
absent from the target. The docstring claimed "they appear naturally
via SELECT *", but the runtime's incremental INSERT path then issues
`INSERT INTO target SELECT * FROM source` against a target whose
schema is fixed — and BigQuery / Snowflake / Databricks all reject
the INSERT with `Inserted row has wrong column count`. The natural
"source schema evolves; replicate again" workflow was structurally
broken.

This PR:

- Adds `added_columns: Vec<ColumnInfo>` to `DriftResult` and populates
  it in `detect_drift` from the same single pass over source columns.
- New helper `drift::generate_add_column_sql` mirroring the existing
  `generate_alter_column_sql`. Standard `ALTER TABLE … ADD COLUMN`
  works across all four adapters today; no dialect override needed.
- Runtime change in `run.rs`: when the drift result reports added
  columns (and DropAndRecreate isn't already firing), execute the
  ALTER statements before continuing with the regular INSERT path.
  Surfaces as `action: "add_columns"` in the run output's
  `drift.actions_taken` so orchestrators can observe schema evolution
  alongside data movement.

Verified end-to-end via the existing `live/drift/run.sh`, extended
into a three-stage flow:

1. Initial replication of a 3-column source (no drift).
2. `ALTER source ADD COLUMN region`; rerun — asserts `add_columns`
   action fires and target gains the column without a full refresh
   (historical rows stay, new rows include the source value).
3. DROP + CREATE source with `id` type changed `INT64`→`STRING`;
   rerun — asserts `drop_and_recreate` action fires and target's
   id column is now STRING.

Idempotent across consecutive runs.

A sibling gap remains: the `AlterColumnTypes` action is detected in
`drift.rs` for safe widenings but the runtime at `run.rs:4105` still
only wires `DropAndRecreate`. Captured as finding #9 in
`live/README.md`; safe widenings silently fall through to the next
INSERT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant