chore(deps-dev): bump @types/node from 25.5.2 to 25.6.0 in /editors/vscode#9
Merged
hugocorreia90 merged 1 commit intomainfrom Apr 13, 2026
Conversation
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 25.5.2 to 25.6.0. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-version: 25.6.0 dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
This was referenced Apr 29, 2026
hugocorreia90
added a commit
that referenced
this pull request
May 1, 2026
…INSERT (#331) `detect_drift` previously ignored columns present in the source but absent from the target. The docstring claimed "they appear naturally via SELECT *", but the runtime's incremental INSERT path then issues `INSERT INTO target SELECT * FROM source` against a target whose schema is fixed — and BigQuery / Snowflake / Databricks all reject the INSERT with `Inserted row has wrong column count`. The natural "source schema evolves; replicate again" workflow was structurally broken. This PR: - Adds `added_columns: Vec<ColumnInfo>` to `DriftResult` and populates it in `detect_drift` from the same single pass over source columns. - New helper `drift::generate_add_column_sql` mirroring the existing `generate_alter_column_sql`. Standard `ALTER TABLE … ADD COLUMN` works across all four adapters today; no dialect override needed. - Runtime change in `run.rs`: when the drift result reports added columns (and DropAndRecreate isn't already firing), execute the ALTER statements before continuing with the regular INSERT path. Surfaces as `action: "add_columns"` in the run output's `drift.actions_taken` so orchestrators can observe schema evolution alongside data movement. Verified end-to-end via the existing `live/drift/run.sh`, extended into a three-stage flow: 1. Initial replication of a 3-column source (no drift). 2. `ALTER source ADD COLUMN region`; rerun — asserts `add_columns` action fires and target gains the column without a full refresh (historical rows stay, new rows include the source value). 3. DROP + CREATE source with `id` type changed `INT64`→`STRING`; rerun — asserts `drop_and_recreate` action fires and target's id column is now STRING. Idempotent across consecutive runs. A sibling gap remains: the `AlterColumnTypes` action is detected in `drift.rs` for safe widenings but the runtime at `run.rs:4105` still only wires `DropAndRecreate`. Captured as finding #9 in `live/README.md`; safe widenings silently fall through to the next INSERT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps @types/node from 25.5.2 to 25.6.0.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)