docs: drift sweep against engine-v1.20.0 (catalog scoping + Phase 5 + lineage-diff)#341
Merged
hugocorreia90 merged 4 commits intomainfrom May 1, 2026
Merged
Conversation
Removes "Phase 1/2/2.5/3/4" internal-roadmap references from public- facing surfaces where they leaked through. Doc-comment / comment-only edits with no behaviour change. - docs/concepts/preview-internals.md — "Phase 1 substrate" / "Phase 1 sampling rule" / "Phase 2.5 lift" → neutral wording - docs/guides/preview-a-pr.md — "Phase 2.5 checksum-bisection" → "planned checksum-bisection" - pocs/01-quality/06-quality-pipeline-standalone (rocky.toml + run.sh) — "Phase 1/2/3/4a/4b" comments → topic-only headings - pocs/06-developer-experience/10-pr-preview-and-data-diff (README.md + run.sh) — "Phases 1, 1.5, 2, 3 merged" / "Phase N not yet wired" / Phase 3-4 prose → reflect actual production status
…d 06-rust-native-adapter-skeleton The Developer Experience and Adapters tables in the playground guide lagged behind the POC directory. Update the POC counts (10→11, 5→6) and add the two missing entries shipped in engine-v1.19.0.
`rocky lineage-diff` shipped in engine-v1.19.0 but was missing from the index lists. One-line additive entries on each surface: - docs/reference/cli.md — Modeling category line - docs/features/all-features.md — Modeling & Compilation chip row - engine/README.md — "CLI at a glance" The full command reference page under docs/reference/commands/modeling/ is left for a follow-up — flagged in the audit report.
Adds the new top-level `job_ids` field to the MaterializationOutput reference table. Shipped in engine-v1.21.0 (#337) — surfaces warehouse- side job IDs so consumers can cross-check rocky-reported bytes against the warehouse console without scraping stderr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Doc + POC drift audit against the engine v1.20.0 / dagster v1.18.0 / vscode v1.11.0 line. Four scoped commits, each addressing one drift class:
f89cdd3) — eight sites indocs/concepts/preview-internals.md,docs/guides/preview-a-pr.md, and two playground POCs were referencing internal phase numbers. Neutralised to topic-only language.docs/guides/playground.md(f552b74) — Developer Experience 10→11 and Adapters 5→6; add entries for11-lineage-diffand06-rust-native-adapter-skeletonshipped in v1.19.0.rocky lineage-diffto CLI index surfaces (d367295) — was missing fromdocs/reference/cli.mdModeling row,docs/features/all-features.mdModeling chip, andengine/README.md"CLI at a glance".MaterializationOutput.job_ids(82aa19c) — new field shipped in PR feat(rocky-cli): emit warehouse job_ids on materialization output + cost cross-check smoke #337 was missing fromdocs/reference/json-output.md.Validation
npm run buildfromdocs/produces 72 pages clean../run.shre-run on both edited POCs (01-quality/06-quality-pipeline-standalone,06-developer-experience/10-pr-preview-and-data-diff) — both pass.Out of scope (flagged for follow-up)
rocky lineage-diffhas no full reference page underdocs/reference/commands/modeling/. Index entries only here; design call on whether to add a full page belongs elsewhere.engine/README.mdadapter status table still says BigQuery + Snowflake are "Beta"; v1.21.0 dropped the BigQuery experimental override. Positioning call.10-pr-preview-and-data-diffPOC triggersinvalid SQL identifier 'branch__pr-preview-poc-10'WARN logs because the POC's--namecontains hyphens. POC still exits 0 but engine refuses to copy unchanged tables on this path. Engine source change needed.Test plan