feat(integrations/dagster): add RockyResource.cost() method + fixture#218
Merged
hugocorreia90 merged 1 commit intomainfrom Apr 22, 2026
Merged
feat(integrations/dagster): add RockyResource.cost() method + fixture#218hugocorreia90 merged 1 commit intomainfrom
hugocorreia90 merged 1 commit intomainfrom
Conversation
Wires the `rocky cost <run_id|latest>` CLI (shipped in engine PR #202) into the Dagster integration. Adds a `RockyResource.cost(run_id="latest")` method that shells out and returns the generated `CostOutput` Pydantic model, plus a unit test for the happy path (default and explicit run_id) and a live-binary fixture captured from the playground POC. - Re-exports `CostOutput` + `PerModelCostHistorical` from `types_generated` and `types.py`, registers `CostOutput` in the `RockyOutput` union and the `parse_rocky_output` dispatch under the `"cost"` command literal. - `scripts/regen_fixtures.sh` now captures `fixtures_generated/cost.json` (the bootstrap `rocky run` at the top of the script already persists the RunRecord that `rocky cost latest` rolls up). - `test_generated_fixtures.py::EXPECTED_TYPES` maps `"cost"` → `CostOutput` so the parse-guard covers the new fixture.
7 tasks
hugocorreia90
added a commit
that referenced
this pull request
Apr 22, 2026
* chore: release engine-v1.14.0 + dagster-v1.10.0 + vscode-v1.6.4 Bumps all three artifacts to cover the 16-PR cascade since engine-v1.13.0 / dagster-v1.9.0 / vscode-v1.6.3. Details in each CHANGELOG. Engine headlines (12 PRs): - Arc 7 wave 2 wave-2 complete — cached DESCRIBE end-to-end (#223 infra, #228 reads, #230 write tap, #231 discover warm-up, #232 state controls + --cache-ttl override) - Arc 2 wave 3 complete — bytes_scanned / bytes_written on MaterializationOutput (#219 BQ, #221 Databricks, #220 Snowflake deferred doc, #222 docstring cascade). Real $ on rocky cost for BQ + Databricks - FR-005 Unity Catalog workspace-binding reconcile (#226) - FR-002 Fivetran connector metadata via SourceOutput.metadata (#225) - Housekeeping: compute_backoff dedup into rocky_core::retry (#217) Dagster headlines (4 PRs): - FR-001 RockyComponent Pipes execution mode + FR-006 strict doctor on RockyResource startup (#224) - FR-003 RockyResource.state_health() (#227) + FR follow-up threading doctor(check=state_rw) for sub-second probes (#229) - RockyResource.cost() wiring + fixture (#218) VS Code: regenerated TS bindings for engine 1.14.0 type additions. No extension feature changes. * chore(integrations/dagster): regenerate test fixtures for engine 1.14.0 36 fixtures picked up the new engine version string in their top-level "version" field. No schema changes — just the version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RockyResource.cost(run_id="latest")— shells out torocky cost <target>and returns the generatedCostOutputPydantic model. Mirrors the shape of the sibling observability methods (history,optimize,doctor).CostOutput/PerModelCostHistoricalthrough thetypes_generatedbarrel andtypes.py, registersCostOutputin theRockyOutputunion and theparse_rocky_outputdispatch under the"cost"command literal.scripts/regen_fixtures.shwith acapture cost cost lateststep (the existing bootstraprocky runpersists theRunRecordthe new command rolls up).fixtures_generated/cost.jsonis committed; the fixture is deterministic through the existing normalizer.test_generated_fixtures.py::EXPECTED_TYPESmaps"cost" → CostOutputso the parse-guard covers the new live-binary capture.parse_rocky_output.Follow-ups not included here (matches the task spec of a single
run_idarg):--modelfilter pass-through (CLI flag already exists; add when a caller needs it).Test plan
uv run pytest -vfromintegrations/dagster/— 312 tests pass locallyuv run ruff check src/ tests/anduv run ruff format --check src/ tests/cleanjust regen-fixturesfrom the monorepo root produces a stablefixtures_generated/cost.jsontest_generated_fixtures.py::test_generated_fixture_parses[cost.json]passes against the captured fixturetest_cost_defaults_to_latest+test_cost_passes_explicit_run_idcover the happy path