refactor(engine/rocky-core): dedup compute_backoff across adapter crates#217
Merged
hugocorreia90 merged 1 commit intomainfrom Apr 22, 2026
Merged
refactor(engine/rocky-core): dedup compute_backoff across adapter crates#217hugocorreia90 merged 1 commit intomainfrom
hugocorreia90 merged 1 commit intomainfrom
Conversation
Hoist the three identical `compute_backoff` copies (rocky-core::state_sync, rocky-databricks::connector, rocky-snowflake::connector) into a single shared `rocky_core::retry::compute_backoff` helper. All three call sites and their existing retry loops are unchanged; only the source of the function moves. Zero behaviour change. The tests from the adapter crates (exponential without jitter, capped, with jitter in range) are consolidated into the new module; duplicate tests in state_sync are removed. Follow-up to #213.
7 tasks
hugocorreia90
added a commit
that referenced
this pull request
Apr 22, 2026
* chore: release engine-v1.14.0 + dagster-v1.10.0 + vscode-v1.6.4 Bumps all three artifacts to cover the 16-PR cascade since engine-v1.13.0 / dagster-v1.9.0 / vscode-v1.6.3. Details in each CHANGELOG. Engine headlines (12 PRs): - Arc 7 wave 2 wave-2 complete — cached DESCRIBE end-to-end (#223 infra, #228 reads, #230 write tap, #231 discover warm-up, #232 state controls + --cache-ttl override) - Arc 2 wave 3 complete — bytes_scanned / bytes_written on MaterializationOutput (#219 BQ, #221 Databricks, #220 Snowflake deferred doc, #222 docstring cascade). Real $ on rocky cost for BQ + Databricks - FR-005 Unity Catalog workspace-binding reconcile (#226) - FR-002 Fivetran connector metadata via SourceOutput.metadata (#225) - Housekeeping: compute_backoff dedup into rocky_core::retry (#217) Dagster headlines (4 PRs): - FR-001 RockyComponent Pipes execution mode + FR-006 strict doctor on RockyResource startup (#224) - FR-003 RockyResource.state_health() (#227) + FR follow-up threading doctor(check=state_rw) for sub-second probes (#229) - RockyResource.cost() wiring + fixture (#218) VS Code: regenerated TS bindings for engine 1.14.0 type additions. No extension feature changes. * chore(integrations/dagster): regenerate test fixtures for engine 1.14.0 36 fixtures picked up the new engine version string in their top-level "version" field. No schema changes — just the version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute_backoffcopies fromrocky-core::state_sync,rocky-databricks::connector, androcky-snowflake::connectorinto a single shared helper atrocky_core::retry::compute_backoff.rocky-core; noCargo.tomlchanges needed.SystemTime::UNIX_EPOCHvsUNIX_EPOCH, inline comments, doc wording).Before / after layout
Before:
After:
Net: 5 files changed, +97 / -196 lines (the new
retry.rsships 90 lines of impl + consolidated tests; the three duplicates and their per-crate test blocks are deleted).Consolidated tests in
retry.rs(covering exponential-no-jitter, capped, with-jitter-in-range) are the superset of what the adapter crates had; the twostate_synctests covered a proper subset.Test plan
cargo test -p rocky-core -p rocky-databricks -p rocky-snowflake— all green (991 + 30 + 20 + supporting suites)cargo clippy --workspace --all-targets -- -D warnings— cleancargo fmt --all --check— cleanengine-ci.yml