fix(engine): install scripts pick latest engine version by semver#169
Merged
hugocorreia90 merged 1 commit intomainfrom Apr 20, 2026
Merged
fix(engine): install scripts pick latest engine version by semver#169hugocorreia90 merged 1 commit intomainfrom
hugocorreia90 merged 1 commit intomainfrom
Conversation
The install scripts and vendor_rocky.sh picked the first engine-v* tag returned by the GitHub releases API, but that endpoint does not sort strictly by published_at in a monorepo with multiple tag prefixes — engine-v1.9.0 was winning over engine-v1.10.0 because 1.9.0 appeared earlier in the response. Lexical sort would have the same problem (v1.10.0 < v1.9.0). Version-sort the engine-prefixed tags and take the highest. Also tighten the tag filter to stable releases only (x.y.z, no suffix) so a future pre-release tag like v2.0.0-rc.1 won't silently become "latest" — sort -V and [version] both rank -rc suffixes above the corresponding stable.
3 tasks
hugocorreia90
added a commit
that referenced
this pull request
Apr 20, 2026
Closes the first wave of every trust-system arc (Arcs 1-7) plus the two wave-2 follow-ups landed the same day. Nine feature PRs since v1.10.0. - Arc 1 (#170): rocky lineage --downstream, rocky branch, rocky run --branch, rocky replay - Arc 2 (#171): per-run cost attribution, [budget] block, budget_breach hook - Arc 3 (#172): three-state CircuitBreaker, adapter consolidation - Arc 4 (#173): rocky trace Gantt + feature-gated OTLP metrics export - Arc 5 (#174): schema-grounded rocky ai prompt + project-aware validator - Arc 6 wave 1 (#184): --target-dialect P001 portability lint (12 constructs) - Arc 7 wave 1 (#185): blast-radius P002 SELECT * lint (semantic-graph aware) - Arc 6 wave 2 (#186): [portability] config block + per-model rocky-allow pragma - Arc 7 wave 2 wave-1 (#187): --with-seed source-schema inference Plus #169 fix: install scripts pick latest engine version by semver. Version bump: 20 Cargo.toml files (all workspace members except rocky-bigquery, which tracks its own version). Wave 2/3 work for every arc remains in the deferred backlog — see the changelog Deferred section for the full carry-forward.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
engine/install.sh,engine/install.ps1, andscripts/vendor_rocky.shall picked the firstengine-v*tag returned by the GitHub releases API. In a monorepo with multiple tag prefixes the API does not sort strictly bypublished_at, soengine-v1.9.0was winning overengine-v1.10.0. Lexical sort would have the same bug (v1.10.0<v1.9.0).sort -V -r | head -1in bash,[version]cast +Sort-Object -Descendingin PowerShell).^engine-v\d+\.\d+\.\d+$(stable only).sort -Vand[version]both rank-rc.1above the corresponding stable — filtering now prevents a future pre-release from silently becoming "latest".Verification
curl … /releases?per_page=30 | grep … | sort -V -r | head -1→engine-v1.10.0✓gh release list … | grep … | sort -V -r | head -1→engine-v1.10.0✓bash -nclean on both shell scripts.Test plan
curl -fsSL https://raw.githubusercontent.com/rocky-data/rocky/main/engine/install.sh | bashresolves toengine-v1.10.0after mergeirm https://raw.githubusercontent.com/rocky-data/rocky/main/engine/install.ps1 | iexresolves toengine-v1.10.0(Windows)scripts/vendor_rocky.sh --releasevendors the 1.10.0 binaryROCKY_VERSION=engine-v1.9.0/bash -s -- 1.9.0still installs the pinned version🤖 Generated with Claude Code