replaced Thread.stop() call with Thread.interrupt() - RobotThreadManager #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flemming-n-larsen
approved these changes
Dec 9, 2025
Member
flemming-n-larsen
left a comment
flemming-n-larsen
left a comment
There was a problem hiding this comment.
Thank you for fixing this! :)
I will do a release soon
Contributor
Author
|
Glad to help! Actually my students caught it. :D I just fixed it so they could keep working. Thanks for the quick response! |
Member
|
@doctorjei You are welcome., and say thanks to the students as well. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Thread.stop() call has been removed as of Java 21, so the old call to stop() would cause the rest of the battle to be aborted; e.g., if you were running 100 rounds, but after the second a robot's thread needs to be terminated, then that would abort the rest of the rounds.
By swapping in interrupt, the thread should still terminate, but gracefully.