Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v1.2 only] Crash on changing graphics page after changing PCjr/Tandy video memory size #102

Closed
32bitkid opened this issue Jun 16, 2019 · 5 comments
Closed

[v1.2 only] Crash on changing graphics page after changing PCjr/Tandy video memory size #102

32bitkid opened this issue Jun 16, 2019 · 5 comments
Assignees
@robhagemans
Labels
bug v1.2 only

Comments

@32bitkid
Copy link

32bitkid commented Jun 16, 2019 •
edited
Loading

Bug report

Problem
When using pcjr/tandy graphics modes and using clear to clear video memory while on a graphical screen, pcbasic does not reset the video mode and will crash if you attempt to access the newly available screen page using screen 4,,1,1 (Rather than returning Illegal function call like it would before the clear command)

On an actual PCjr, when the clear command is not a noop, it resets the screen to mode 0. I do not have a Tandy available for testing.

Program

$ pcbasic --preset=pcjr

10 screen 4
20 clear ,,,32768!
30 screen 4,,1,1

Crash log

EXCEPTION                                                                       
:SCREEN 4,0,1,1                                                                                                                                                 
pcbasic.statements:169, parse_statement                                         
    None                                                                        
pcbasic.statements:2501, exec_screen                                            
    None                                                                        
pcbasic.backend:1040, screen                                                    
    None                                                                        
pcbasic.backend:1187, set_page                                                  
    None                                                                        
IndexError: list index out of range

Notes

PC-BASIC version: 1.2.14 and 2.0.2beta
Operating system version: MacOS 10.14.5
@robhagemans robhagemans self-assigned this Jun 18, 2019
@robhagemans
Copy link
Owner

Thank you for reporting this! Looks like there is an issue with keeping track of the video page when the number of pages changes.

Also thanks especially for confirming PCjr behaviour, as I only have access to emulators...

@robhagemans robhagemans changed the title Issue with clear when in graphics mode Crash on changing graphics page after changing PCjr/Tandy video memory size Jun 18, 2019
@robhagemans
Copy link
Owner

Reproduced on both 1.2 and 2.0 branches

@robhagemans
Copy link
Owner

Tried this on DOSBox with Tandy emulation and Tandy GW-BASIC and it hangs, so unclear what real Tandy hardware does here. I'm going with dropping to text as with the pcjr

@robhagemans
Copy link
Owner

This is now fixed on develop for next release on 2.0 branch, hence marking as 1.2 only

@robhagemans robhagemans changed the title Crash on changing graphics page after changing PCjr/Tandy video memory size Crash on changing graphics page after changing PCjr/Tandy video memory size (v1.2) Sep 26, 2020
robhagemans added a commit that referenced this issue Sep 26, 2020
@robhagemans
include test for issue #102 crash on changing graphics page after cha…
8a72488 
…nging PCjr/Tandy video memory size
robhagemans added a commit that referenced this issue Sep 26, 2020
@robhagemans
fix issue #102 crash on changing graphics page after changing PCjr/Ta…
89a5e3c 
…ndy video memory size
@robhagemans robhagemans changed the title Crash on changing graphics page after changing PCjr/Tandy video memory size (v1.2) [v1.2 only] Crash on changing graphics page after changing PCjr/Tandy video memory size Oct 11, 2020
robhagemans added a commit that referenced this issue Nov 7, 2021
@robhagemans
backport fix for issue #102 - crash on changing graphics page after c…
4298390 
…hanging video memory size
@robhagemans
Copy link
Owner

Fixed on release-1.2 branch by commit 4298390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robhagemans robhagemans

Labels
bug v1.2 only
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@32bitkid @robhagemans