Merged
Conversation
List of updates/fixes: * Allow reading not only xlsx format but also xls, ods, xlsb * Allow Excel DateTime format and transform it to arrow Timestamp(Seconds, None) * Allow using NULLs in any data types and use null value instead of string "null" * Fix issue with incorrect data type inference when multiple data types are detected. * Add possibility to specify data schema in config. * Add new options: - rows_range_start - rows_range_end - columns_range_start - columns_range_end - schema_inference_lines * Make sheet_name optional and if it is not specified than use first sheet by default * Bump calamine crate to version 0.23.1 and add feature "dates" (supporting for DateTime column format)
This was referenced Jan 7, 2024
Contributor
Author
|
Hi, @houqp 👋 I am finally started learning and coding in rust 🎉 and really appreciate your review of this PR. |
houqp
approved these changes
Feb 1, 2024
Member
|
Great to see you again @Maks-D ! Sorry that I have been really busy over the past 2 weeks and missed your PR :) Your write very clean and easy to understand Rust code, great job. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fix for issue #259
List of updates/fixes:
Documentation updates: roapi/docs#20