fix(postgres): ignore non-select queries#252
Merged
houqp merged 1 commit intoroapi:mainfrom Jan 29, 2023
Merged
Conversation
houqp
force-pushed
the
qp_postgres
branch
2 times, most recently
from
c356e4e to
3e45071
Compare
jychen7
reviewed
Jan 29, 2023
| let query = statement.to_string(); | ||
| let df = self.ctx.sql_to_df(&query).await.map_err(df_err_to_sql)?; | ||
| Ok(DataFusionPortal { df }) | ||
| if RoapiContextEngine::<H>::ignored_statement(statement) { |
Collaborator
There was a problem hiding this comment.
[minor] will following cleaner if modify slightly?
let query = if RoapiContextEngine::<H>::ignored_statement(statement) {
"SELECT 1 WHERE 1 = 2".to_string()
} else {
statement.to_string()
};
let df = self.ctx.sql_to_df(&query).await.map_err(df_err_to_sql)?;
Ok(DataFusionPortal { df })
Member
Author
There was a problem hiding this comment.
yeah i agree. I think ideally, we create an empty dataframe in the ignore branch instead of using a workaround query to avoid unnecessary query parsing and execution.
jychen7
approved these changes
Jan 29, 2023
Collaborator
lol, that's why so instant |
jychen7
reviewed
Jan 29, 2023
| Ok(DataFusionPortal { | ||
| df: self | ||
| .ctx | ||
| .sql_to_df("SELECT 1 WHERE 1 = 2") |
Collaborator
There was a problem hiding this comment.
If I understand correctly, where 1 = 2 is added to make sure return empty result
Member
Author
There was a problem hiding this comment.
yeah, it's hacky, if you have better ideas, let me know!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #180