Conversation
Signed-off-by: Valery Piashchynski <[email protected]>
rustatian
added
the
C-enhancement
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Release PR for the v2025.1.7 stable cycle, primarily updating the project/tooling to a newer Go version and refreshing the v2025 RoadRunner template baseline, along with CI/linting adjustments.
Changes:
- Bump Go/toolchain references (go.mod, Dockerfile, template go.mod) and update Go module dependencies.
- Refresh v2025 template dependency pins (e.g., tablewriter/cobra/testify).
- Update GitHub Actions workflows and add package-level
doc.gofiles across packages.
Reviewed changes
Copilot reviewed 18 out of 20 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| logger/doc.go | Adds package-level GoDoc entry for logger package. |
| internal/version/doc.go | Adds package-level GoDoc entry for version helpers. |
| internal/cli/doc.go | Adds package-level GoDoc entry for CLI wiring. |
| internal/cli/build/doc.go | Adds package-level GoDoc entry for build command package. |
| gitlab/doc.go | Adds package-level GoDoc entry for GitLab client package. |
| github/doc.go | Adds package-level GoDoc entry for GitHub client package. |
| doc.go | Adds package-level GoDoc entry for root velox package. |
| cmd/vx/doc.go | Adds package-level GoDoc entry for main CLI package. |
| builder/doc.go | Adds package-level GoDoc entry for builder package. |
| builder/templates/doc.go | Adds package-level GoDoc entry for templates package. |
| builder/templates/templateV2025.go | Updates v2025 generated RoadRunner go.mod template (Go version + dependency pins). |
| builder/builder.go | Removes //nolint:prealloc on a slice that is appended to. |
| go.mod | Bumps Go version and updates dependency versions. |
| go.sum | Regenerates sums for updated dependencies. |
| Dockerfile | Updates Go base images to 1.26-alpine and tweaks formatting. |
| .golangci.yml | Enables revive default rules (with var-naming disabled). |
| .gitignore | Narrows vx ignore to repo root (/vx). |
| .github/workflows/release.yml | Updates action versions and adjusts build/release scripting. |
| .github/workflows/linux.yml | Updates action versions and cache action major version. |
| .github/workflows/linters.yml | Updates action versions for checkout/setup-go/golangci-lint. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - name: Check out code | ||
| uses: actions/checkout@v4 | ||
|
|
||
| uses: actions/checkout@v5 |
There was a problem hiding this comment.
build-sample-rr uses actions/checkout@v5 while the golang job uses actions/checkout@v6. If the version bump is intentional, it should be consistent across jobs; otherwise pin both jobs to the same (known-good) major version to reduce CI drift.
| uses: actions/checkout@v5 | |
| uses: actions/checkout@v6 |
|
|
||
|
|
||
|
|
||
|
|
||
| [ ${{ matrix.os }} != '' ] && echo '${{ matrix.os }}' || echo 'unknown' | ||
| )$( | ||
|
|
||
|
|
||
|
|
||
|
|
||
| [ ${{ matrix.compiler }} = 'musl-gcc' ] && echo '-musl' |
There was a problem hiding this comment.
This run: > step tests [ ${{ matrix.os }} != '' ] without quoting the expanded value. For the matrix entry where os: "", this becomes [ != '' ] and will error in [/bash, breaking the release build. Quote the expression expansions in the test (and consider removing the extra blank lines here to keep the script readable).
| [ ${{ matrix.os }} != '' ] && echo '${{ matrix.os }}' || echo 'unknown' | |
| )$( | |
| [ ${{ matrix.compiler }} = 'musl-gcc' ] && echo '-musl' | |
| [ "${{ matrix.os }}" != '' ] && echo '${{ matrix.os }}' || echo 'unknown' | |
| )$( | |
| [ "${{ matrix.compiler }}" = 'musl-gcc' ] && echo '-musl' |
| run: | | ||
| echo "version=$(echo ${GITHUB_REF##*/} | sed -e 's/^[vV ]*//')" >> $GITHUB_OUTPUT | ||
| echo "timestamp=$(echo $(date +%FT%T%z))" >> $GITHUB_OUTPUT | ||
| echo "binary-name=$(echo $(echo vx`[ ${{ matrix.os }} = 'windows' ] && echo '.exe'`))" >> $GITHUB_OUTPUT |
There was a problem hiding this comment.
This shell test uses an unquoted ${{ matrix.os }}: when the matrix entry has os: "", it expands to [ = 'windows' ] which causes a bash [ syntax error and will break the workflow. Quote the expanded value in the test (e.g., [ "${{ matrix.os }}" = 'windows' ]).
| var result []*templates.Entry | ||
| replaces := replaceRegexp.FindAllStringSubmatch(string(modFile), -1) |
There was a problem hiding this comment.
prealloc linter is enabled in .golangci.yml; removing the previous //nolint:prealloc here will likely reintroduce a lint failure. Either preallocate result (e.g., based on len(replaces)) or restore the targeted nolint if preallocation isn’t appropriate.
| var result []*templates.Entry | |
| replaces := replaceRegexp.FindAllStringSubmatch(string(modFile), -1) | |
| replaces := replaceRegexp.FindAllStringSubmatch(string(modFile), -1) | |
| result := make([]*templates.Entry, 0, len(replaces)) |
1 participant
Reason for This PR
Description of Changes
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).CHANGELOG.md.