refactor(acl): enhance publish ACL handling with detailed result codes #311 #328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace simple PublishAclResult enum with structured PublishResult containing reason codes * Add PublishAclResult wrapper with helper methods for ACL checks * Implement proper MQTT v5 reason codes for publish authorization results * Update all ACL plugins (acl, auth-http, auth-jwt) to use new result structure * Fix QoS 2 publish handling to only add to inflight on successful publish * Add detailed error reporting with reason strings for publish failures * Maintain backward compatibility while improving protocol compliance
* Update GitHub CI workflow to use Rust 1.88.0 as minimum supported version * Update Rust version badges in both Chinese and English README files * Maintain compatibility with all existing features and functionality
* Bump rmqtt-storage dependency to exact version 0.7.4 for both message and session storage plugins * Fix test assertion in types.rs to match updated reason string formatting * Maintain all existing storage functionality with updated dependency versions
…rmatting
* Update GitHub CI workflow to use Rust 1.89.0 as minimum supported version
* Update Rust version badges in both Chinese and English README files
* Apply consistent inline string formatting across all logging statements
* Replace `{}` placeholders with `{variable}` syntax for better readability
* Maintain all existing functionality with updated toolchain requirements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.