-
-
Notifications
You must be signed in to change notification settings - Fork 706
Removing public symlink to its own directory #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@philfreo The repository is designed to be published to GitHub pages. It is also designed to be used with Pow in my local development environment, hence the need for the I'm not familiar with Django's collectstatic, but it sounds like it has a bug (or an undesirable feature) that's worth fixing there. It looks like collectstatic also has support for ignoring directories matching a glob pattern. You're free to further justify a change to the timeago repository, but given my development workflow, it's currently unlikely that I'll accept this patch. |
|
"a bug (or an undesirable feature)"
Do you traverse this way...: ...or more like this? :-D If this is just your personal development repository (and seeing as you're defending infinite recursion) then I guess ths stays closed! |
|
@appastair I do not understand nor do I appreciate the snarky nature of your comment. Were you not happy with my original explanation?
Not true. The parent directory hosts the documentation page and the test suite that I access for final testing before a release. As I've already explained, I use GitHub pages for publishing this project and Pow to manage the dozens of projects that I work on day-to-day, and being able to access each by name without worrying about virtual host config entries and without starting servers on random ports is a productivity boost. Pow relies on a public directory for static content, and the symlink prevents me from ever having to think about or work in the public directory. E.g. I can access static content at http://timeago.dev/ at anytime simply because my timeago directory has a public directory in it.
Hey look, a scarecrow! I never defended infinite recursion. The public symlink is perfectly accessible as it is, because it is not infinite recursion (unless you're defending the case of perpetually changing to the same directory again and again for the hell of it). Next time, please consider explaining a problem that you're actually having. Is it that your toolchain can't handle this public symlink? I would suggest adding some ignore rule to your tools, or perhaps you should take the underlying issue up with the maintainers of that tool. Whining about how I setup my environment doesn't make it conducive for me to help you. Better yet, come up with an alternative solution that meets the underlying requirements and propose that. 😄 |
|
Sorry. I did mean the parent directory, not itself but the infinite I understand your workflow but it seems that it's causing issues (though
|
Why would it be more widespread? What are IDEs like NetBeans doing that causes them to go into infinite loops? Why do they need try to traverse all directories? The fact that the file system itself and the GUI tools around it that come bundled with the operating system can handle a recursive symlink without blowing up is perfect evidence why the NetBeans behavior is broken. Lastly, what were you trying to do with the repository that landed you in NetBeans hell? Were you planning to fork it and submit a pull-request? Were you pulling it into your work repository in the form a of a git submodule (or similar) for inclusion in your project? I'd like to understand the workflow that led to this discussion. |
|
I noticed it by adding it as a submodule and NetBeans issues an error whenever I search for something.
Further testing in the shell doesn't give the same recursion from anything I tried so apart from manually |
|
@appastair Thanks for the additional details. Honestly, you should consider submitting a bug report to NetBeans. |
|
NetBeans Bug 218795 - FileObject.getChildren(true) should handle recursive symlinks gracefully |
|
Update: I reconsidered this issue mainly because I'm tired of hearing about projects that are forced to use tools with this common bug of not being able to handle symlinks properly. I removed the public symlink. |
|
I feel like one of the bad guys now... 😦 I completely understand where you were coming from and I'm not so familiar with any of the more popular tools that have this issue but in my experiences, at least it's rarely an issue. I guess...that's how it goes with everything IE : Instead of doing the correct thing, one has to begrudgingly go the extra distance because other people won't fix their broken/non-compliant stuff! 😉 |

Having a symlink that points to its own directory is a problem for some scripts that recurse through every folder.
I had a specific problem where this caused Django's collectstatic management command to run into an infinite loop.