Skip to content

Add thermal components in mvs#954

Merged
Bachibouzouk merged 21 commits intodevfrom
feature/open_plan_assets
Apr 25, 2024
Merged

Add thermal components in mvs#954
Bachibouzouk merged 21 commits intodevfrom
feature/open_plan_assets

Conversation

@Bachibouzouk
Copy link
Copy Markdown
Collaborator

@Bachibouzouk Bachibouzouk commented Sep 19, 2022

Due to lack of time for maintaing, this PR will not be cleant and reviewed as state of the art git practice , tests have been tun locally and passed, linting was also done locally, somehow the action linting fails. The next step will be to update python version and linter version anyway so I will pass on those failing tests

Additionally, the failing doc needs to be resolved due to a new requirements for the build

Changes proposed in this pull request:

  • Described in Changelog

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@Bachibouzouk Bachibouzouk force-pushed the feature/open_plan_assets branch from e9a1daa to c77af29 Compare September 23, 2022 09:53
@Bachibouzouk Bachibouzouk force-pushed the feature/open_plan_assets branch from 179146a to 36533a4 Compare October 19, 2022 16:10
@Bachibouzouk Bachibouzouk force-pushed the feature/open_plan_assets branch from 36533a4 to 242b4f0 Compare October 31, 2022 20:06
@Bachibouzouk Bachibouzouk force-pushed the feature/open_plan_assets branch 4 times, most recently from dbb0038 to c9c6245 Compare February 3, 2023 15:50
@Bachibouzouk Bachibouzouk mentioned this pull request Feb 3, 2023
7 tasks
@Bachibouzouk Bachibouzouk force-pushed the feature/open_plan_assets branch from c9c6245 to 6d2a204 Compare April 25, 2024 08:40
@Bachibouzouk Bachibouzouk marked this pull request as ready for review April 25, 2024 09:01
@Bachibouzouk Bachibouzouk merged commit 1e56e39 into dev Apr 25, 2024
@Bachibouzouk Bachibouzouk deleted the feature/open_plan_assets branch April 25, 2024 09:01
@Bachibouzouk Bachibouzouk mentioned this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant