Merged
Conversation
Collaborator
Author
|
@NargesChinichian - we should add a test for this component, for example if the beta parameter is not provided |
Bachibouzouk
commented
Sep 8, 2022
Collaborator
Author
Bachibouzouk
left a comment
Bachibouzouk
left a comment
There was a problem hiding this comment.
Still need to add a test for raising error if beta is not provided
Think of the case where people define a parameter for beta when it was not needed, we should also have an error raised in that case
| ) | ||
|
|
||
| model.add(ext_turb_chp) | ||
| kwargs[OEMOF_ExtractionTurbineCHP].update({dict_asset[LABEL]: ext_turb_chp}) |
Collaborator
Author
There was a problem hiding this comment.
I guess you forgot to push the change where you define OEMOF_ExtractionTurbineCHP
Collaborator
|
The structure now is that it goes to extraction turbine chp only if a beta is provided. We can't check for the wrong addition of beta with this logic. |
Bachibouzouk
force-pushed
the
fix/chp_component
branch
from
de89356 to
ea2f67c
Compare
2 tasks
Bachibouzouk
force-pushed
the
fix/chp_component
branch
7 times, most recently
from
dbb0446 to
313faed
Compare
Co-authored-by: [email protected]
If uploaded timeseries did not have timestamps there was an error
Expected inputs of chp are two efficiencies for the heat and electricity busses and the beta factor (power losses) Co-authored-by: [email protected]
function E1.add_info_flows, E1.get_results and E2.get_costs were modified as well as the data_parser
Bachibouzouk
force-pushed
the
fix/chp_component
branch
from
cd7189a to
620cfc4
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR need to be rebased on
devonce #956 is mergedFix #803
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)