Fix maximum capacity for server simulation#939
Merged
Bachibouzouk merged 5 commits intodevfrom May 18, 2022
Merged
Conversation
095e16c to
998736f
Compare
9 tasks
b14761b to
5339d03
Compare
7 tasks
ciaradunks
approved these changes
Apr 8, 2022
Instead of the existence of the FILENAME key in asset dict
Only production assets have maximum_capacity available Change returned field name from OPTIMIZED_ADD_CAP to "optimized_add_cap"
5339d03 to
b52293b
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The maximum cap parameter triggers errors when implemented form the simulation server. This is an attempt to fix the problems
Changes proposed in this pull request:
OPTIMIZED_ADD_CAPreplaced by "optimized_add_cap" in the assets keys returned to EPA after simulatingMAXIMUM_CAPfor non-dispatchable production assets is now based on the value ofDISPATCHABILITYand not on the existence of the keyFILENAMEin theasset_dictThe following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.