Skip to content

Fix maximum capacity for server simulation#939

Merged
Bachibouzouk merged 5 commits intodevfrom
fix/maximum-capacity-server
May 18, 2022
Merged

Fix maximum capacity for server simulation#939
Bachibouzouk merged 5 commits intodevfrom
fix/maximum-capacity-server

Conversation

@Bachibouzouk
Copy link
Copy Markdown
Collaborator

@Bachibouzouk Bachibouzouk commented Apr 5, 2022

The maximum cap parameter triggers errors when implemented form the simulation server. This is an attempt to fix the problems

Changes proposed in this pull request:

  • OPTIMIZED_ADD_CAP replaced by "optimized_add_cap" in the assets keys returned to EPA after simulating
  • The if statement for adapting MAXIMUM_CAP for non-dispatchable production assets is now based on the value of DISPATCHABILITY and not on the existence of the key FILENAME in the asset_dict
  • "maximum_add_cap" to the keys returned to EPA after simulating got production assets

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@Bachibouzouk Bachibouzouk force-pushed the fix/maximum-capacity-server branch from 095e16c to 998736f Compare April 7, 2022 09:58
@Bachibouzouk Bachibouzouk marked this pull request as ready for review April 7, 2022 09:59
@Bachibouzouk Bachibouzouk requested a review from ciaradunks April 7, 2022 10:00
@Bachibouzouk Bachibouzouk force-pushed the fix/maximum-capacity-server branch 2 times, most recently from b14761b to 5339d03 Compare April 7, 2022 10:37
@Bachibouzouk Bachibouzouk mentioned this pull request Apr 7, 2022
7 tasks
Instead of the existence of the FILENAME key in asset dict
Only production assets have maximum_capacity available
Change returned field name from OPTIMIZED_ADD_CAP to "optimized_add_cap"
@Bachibouzouk Bachibouzouk force-pushed the fix/maximum-capacity-server branch from 5339d03 to b52293b Compare May 18, 2022 09:22
@Bachibouzouk Bachibouzouk merged commit df995df into dev May 18, 2022
@Bachibouzouk Bachibouzouk deleted the fix/maximum-capacity-server branch May 18, 2022 09:33
@Bachibouzouk Bachibouzouk mentioned this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants