Skip to content

Freeze numpy version#924

Merged
Bachibouzouk merged 2 commits intodevfrom
hotfix/freeze-numpy-version
Sep 29, 2021
Merged

Freeze numpy version#924
Bachibouzouk merged 2 commits intodevfrom
hotfix/freeze-numpy-version

Conversation

@Bachibouzouk
Copy link
Copy Markdown
Collaborator

@Bachibouzouk Bachibouzouk commented Sep 16, 2021

Addresses temporarily #908 by treating symptoms but not the cause

Changes proposed in this pull request:

  • Set numpy version to lower or equal than 1.19.4

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

For more information on how to contribute check the CONTRIBUTING.md.

Bachibouzouk and others added 2 commits September 16, 2021 14:50
Addresses temporarily #908 by treating symptoms but not the cause
Copy link
Copy Markdown
Collaborator

@smartie2076 smartie2076 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fitting Hotfix ;)

@Bachibouzouk Bachibouzouk merged commit e3bc85f into dev Sep 29, 2021
@Bachibouzouk Bachibouzouk deleted the hotfix/freeze-numpy-version branch September 29, 2021 13:27
@Bachibouzouk Bachibouzouk mentioned this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants