Skip to content

Print objective value in simulation output#901

Merged
smartie2076 merged 6 commits intodevfrom
fix/objective_value
Jun 22, 2021
Merged

Print objective value in simulation output#901
smartie2076 merged 6 commits intodevfrom
fix/objective_value

Conversation

@smartie2076
Copy link
Copy Markdown
Collaborator

@smartie2076 smartie2076 commented Jun 17, 2021

Fix #900

Changes proposed in this pull request:

  • Add simulation inputs for tests/inputs/objective_value_exception_equal_annuity_total
  • Add pytest for F0.TestLogCreation.test_parse_simulation_log and benchmark test of OBJECTIVE_VALUE
  • Fix F0.TestLogCreation.test_parse_simulation_log
  • Constants BENCHMARK_TEST_INPUT_FOLDER and BENCHMARK_TEST_OUTPUT_FOLDER in tests/_constants.py (Print objective value in simulation output #901)

The following steps were realized, as well (if applies):
❌ Use in-line comments to explain your code
❌ Write docstrings to your code (example docstring)
❌ For new functionalities: Explain in readthedocs

  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

@smartie2076 smartie2076 added the bug Something isn't working label Jun 17, 2021
…UT_FOLDER`

- `BENCHMARK_TEST_INPUT_FOLDER = "benchmark_test_inputs"`
- `BENCHMARK_TEST_OUTPUT_FOLDER = "benchmark_test_outputs"`
- Replace "csv" with `CSV_EXT`
@smartie2076 smartie2076 merged commit 337ee5c into dev Jun 22, 2021
@smartie2076 smartie2076 deleted the fix/objective_value branch June 22, 2021 20:09
@Bachibouzouk Bachibouzouk mentioned this pull request Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Objective Value not in the simulation results

1 participant