Skip to content

Fix minor issues in autoreport#875

Merged
smartie2076 merged 8 commits intodevfrom
fix/autoreport
May 27, 2021
Merged

Fix minor issues in autoreport#875
smartie2076 merged 8 commits intodevfrom
fix/autoreport

Conversation

@smartie2076
Copy link
Copy Markdown
Collaborator

@smartie2076 smartie2076 commented Apr 29, 2021 •
edited
Loading

Fix #762

Changes proposed in this pull request:

  • Fix E2.convert_components_to_dataframe(): Display correctly when assets (esp. storage) is optimized

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
    ❌ For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

@smartie2076 smartie2076 added the bug Something isn't working label Apr 29, 2021
@smartie2076 smartie2076 self-assigned this Apr 29, 2021
@smartie2076
Copy link
Copy Markdown
Collaborator Author

smartie2076 commented Apr 29, 2021

Another identified issue:
grafik
Used here
https://github.com/rl-institut/multi-vector-simulator/blob/dev/src/multi_vector_simulator/F2_autoreport.py#L783
And with default definitions here:
https://github.com/rl-institut/multi-vector-simulator/blob/dev/src/multi_vector_simulator/utils/constants.py#L264
The scenario_definition parameter is defined, but still there is an error message:

16:49:38-ERROR-Parameter scenario_description of asset project_data (group: project_data) is missing. The simulation may continue, but errors during execution or in the results
can be expected.

@smartie2076 smartie2076 marked this pull request as draft April 29, 2021 15:19
@Bachibouzouk
Copy link
Copy Markdown
Collaborator

Bachibouzouk commented May 3, 2021

Is there a specific input data folder which one should use for testing the PR works? @smartie2076 ?

@smartie2076
Copy link
Copy Markdown
Collaborator Author

smartie2076 commented May 3, 2021

Is there a specific input data folder which one should use for testing the PR works? @smartie2076 ?

The tests/inputs folder works for this, actually. The PR is not done, though!

@smartie2076
Fix F2.convert_components_to_dataframe()
3e6a4eb 
- Improve docstrings
- Restructuring and refactoring for more intuitive code
- Fix: Display correctly when a storage asset is optimized
@smartie2076
Copy link
Copy Markdown
Collaborator Author

smartie2076 commented May 18, 2021

Another identified issue:
grafik
Used here
https://github.com/rl-institut/multi-vector-simulator/blob/dev/src/multi_vector_simulator/F2_autoreport.py#L783
And with default definitions here:
https://github.com/rl-institut/multi-vector-simulator/blob/dev/src/multi_vector_simulator/utils/constants.py#L264
The scenario_definition parameter is defined, but still there is an error message:

16:49:38-ERROR-Parameter scenario_description of asset project_data (group: project_data) is missing. The simulation may continue, but errors during execution or in the results
can be expected.

This was a bug with the input files of tests/inputs, not a code-bug.

@smartie2076
Fix issue as to why some assets are mislabelled as not optimized
890f623 
- Add pytest for E1.convert_components_to_dataframe()
- Create a new sub-function `E1.translate_optimizeCap_from_boolean_to_yes_no()` to ease testing
@smartie2076
Fix tests/inputs typo
9a4fcd3
@smartie2076
Use OEMOF_ASSET_TYPE OEMOF_SOURCE in D1
65d5044
@smartie2076
Update changelog.md
443cec7
@smartie2076 smartie2076 marked this pull request as ready for review May 18, 2021 15:32
@smartie2076
Copy link
Copy Markdown
Collaborator Author

smartie2076 commented May 18, 2021

Previously, the diesel generator and storage assets where faulty. Now I fixed this:
grafik

Bachibouzouk
Bachibouzouk reviewed May 19, 2021
View reviewed changes
@smartie2076 smartie2076 merged commit 67ea3a4 into dev May 27, 2021
@smartie2076 smartie2076 deleted the fix/autoreport branch May 27, 2021 14:19
@smartie2076 smartie2076 mentioned this pull request May 31, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bachibouzouk Bachibouzouk Bachibouzouk approved these changes

Assignees

@smartie2076 smartie2076

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] Report shows wrong value for capacity optimization

2 participants

@smartie2076 @Bachibouzouk