Prevent github action workflow for changes on docs#872
Conversation
|
I will wait until the check have passed and will then change something in the README to see what happends then |
|
The problem then is that as the test never were triggered, we can only merge as administrators, but maybe it is still ok (I wanted to avoid the servers to run the tests if no files related to tests were changed anyway), what do you think @smartie2076 ? |
smartie2076
left a comment
smartie2076
left a comment
There was a problem hiding this comment.
Its a good idea - we need to make sure, though, that the RTD tests (ie. compilation without warnings) is still run. As I have shown you, this is never the case on Windows locally, so if we do not test this we will actually collect a lot of warnings again.
Is a warning-free RTD compilation tested? Then you can merge as admin.
README.rst
Outdated
| Test | ||
|
|
There was a problem hiding this comment.
| Test |
The RTD compilation is done on the readthedocs side not from github actions (you can see that the doc ran for this current PR) |
Ah, I thought this would only test that it can be compiled, not that it is compiled without warnings. |
The warning settings is in the |
Bachibouzouk
force-pushed
the
feature/no_tests_docs
branch
from
9ca8067 to
01ea4ae
Compare
2 participants
It should prevent to have to wait for the test on the .py and coverage to pass if we change only the documentation .rst files
Leading to less waiting time and avoid using githubaction servers for nothing
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)For more information on how to contribute check the CONTRIBUTING.md.