Merged
Conversation
Bachibouzouk
force-pushed
the
fix/coverage
branch
from
e422eda to
119b19e
Compare
smartie2076
approved these changes
Apr 20, 2021
| - Readthedocs restructure of chapters (#853, #860) | ||
| - Load svg badges only for html readthedocs (#857) (reversed in #860) | ||
| - Turn docs build warnings into errors (#863) | ||
| - Pytest runs the kpi benchmark tests (which was not the case before) (#864) |
Collaborator
There was a problem hiding this comment.
Where in your commits did you change that?
Bachibouzouk
commented
Apr 20, 2021
| - name: Test with pytest | ||
| run: | | ||
| coverage run -m pytest tests/ -k "not test_benchmark_kpi" --durations-min=1.0 --durations=400 | ||
| coverage run -m pytest tests/ --durations-min=1.0 --durations=400 |
Collaborator
Author
There was a problem hiding this comment.
@smartie2076 This is the line where I removed the code which exluded the test_benchmark_kpi
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #669
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)For more information on how to contribute check the CONTRIBUTING.md.