Merged
Conversation
547f533 to
3876c40
Compare
Contributor
c3b0c20 to
1be7791
Compare
1be7791 to
5592c6f
Compare
5592c6f to
3af3f10
Compare
Collaborator
Author
I don't know either, maybe refresh your local browser? The online build works well
Agreed
That was a mistake from me, I corrected it If you are reviewing a PR and the person could merge it after implementing your suggestion, it is best to comment and still approve it so that approval does not need to be awaited. It kinda depends on who's writing the PR, for brand new developer you might still want to double check, or if the PR is on master for an important release then it is ok to make sure everything is perfect before approval ;) |
Contributor
|
@Bachibouzouk yeah that's very logical! Will do that from now on |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix #849
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)For more information on how to contribute check the CONTRIBUTING.md.