Skip to content

Use the badges only for html production and not latex#857

Merged
Bachibouzouk merged 2 commits intodevfrom
fix/RTD-build
Apr 13, 2021
Merged

Use the badges only for html production and not latex#857
Bachibouzouk merged 2 commits intodevfrom
fix/RTD-build

Conversation

@Bachibouzouk
Copy link
Copy Markdown
Collaborator

@Bachibouzouk Bachibouzouk commented Apr 13, 2021

Related to #849

Changes proposed in this pull request:
Escape svg images from badges in latex

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

For more information on how to contribute check the CONTRIBUTING.md.

@Bachibouzouk
Copy link
Copy Markdown
Collaborator Author

Unfortunately oone can only trigger latex build from dev (and thus the fact that documentation builds now is no indication it will work then ...)

Copy link
Copy Markdown
Collaborator

@smartie2076 smartie2076 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This means that the badges are only for the online version, right?

@smartie2076
Copy link
Copy Markdown
Collaborator

Unfortunately oone can only trigger latex build from dev (and thus the fact that documentation builds now is no indication it will work then ...)

This is connected to #849? Ie. locally latex builds are tested, but sadly this does not mean that they work online?

@Bachibouzouk Bachibouzouk merged commit 772e3f6 into dev Apr 13, 2021
@smartie2076 smartie2076 mentioned this pull request Apr 13, 2021
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants