Conversation
94ccd1d to
9c5d26c
Compare
|
@smartie2076 after making the suggested changes and running the tests, KeyError: 'maximumAddCap' is returned from D1.transformer_constant_efficiency_optimize(), for instance. Do you have an idea of why this is happening? |
|
Yes, I do! It is the same thing that was the case in the other PR: The input files for the |
7523af5 to
3262688
Compare
smartie2076
left a comment
There was a problem hiding this comment.
I didnt get that far yet with my review, sorry. Will continue later.
smartie2076
left a comment
There was a problem hiding this comment.
Nice, almost done! There is this pending issue about which error types we should use for the MVS, I hope @Bachibouzouk can enlighten us ;)
Do you also see the benefits of also having an MAXIMUM_ADD_CAP_NORMALIZED? It would only be used in energyProduction assets...
99b3d04 to
92f79c7
Compare
29895eb to
3f06a5a
Compare
…on using CSV plugin
Co-authored-by: smartie2076 <[email protected]>
…ormalized in inputs for D1
3f06a5a to
8890878
Compare
Fix #Issue
Changes proposed in this pull request:
MaximumAddCap(whereMaximumAddCap=MaximumCap-InstalledCap) inC0.process_maximum_cap_constraintMaximumCap<=InstalledCapinC0.process_maximum_cap_constraintMaximumCapdefinition in RTD and include definition forMaximumAddCapMaximumCapinD1withMaximumAddCapcalculated inC0The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)For more information on how to contribute check the CONTRIBUTING.md.