Feature/energy system max demand fulfillment fix#844
Merged
ciaradunks merged 7 commits intofeature/energy_system_max_demand_fulfillmentfrom Mar 29, 2021
Conversation
- Remove if-loop with `DISPATCHABILITY` - Remove indentation of ENERGY_PRODUCTION, with looped it into the ENERGY_CONVERSION assets
…lfill_max_demand()`
Collaborator
Author
|
My last commit now fixed the failing benchmark test. This means, however, that you need to adapt your pytests to also cover fuel sources and their exceptions. Edit: Ie. you need a seperate test for |
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @ciaradunks I found the issues why the check did not work. I commited in very small batches, so that you can check where what went wrong. I also added a pseudo-benchmark test that assessed whether the check was running in general.
There are two failing tests now.
This one is interesting, as
timeseries_peakseems to be missing. All non-dispatchable PV assets have this parameter, so what could this be? It is the exception that we define a fuel source inenergyProduction.csv. There must be an exeption for this case.And
Which I think is unimportant.