Sort out dependencies in requirements.txt#840
Merged
smartie2076 merged 4 commits intodevfrom Mar 25, 2021
Merged
Conversation
smartie2076
approved these changes
Mar 25, 2021
Collaborator
smartie2076
left a comment
There was a problem hiding this comment.
Yes, then we should use the most recent pandas version! Wonder why we did not use it before, then.
eacdc60 to
30977cc
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #836, fix #760, fix #200
I tried python 3.8 and 3.9, I let install the latest panda version (v1.2.3, .. happen only once ^^) and all the tests ran smoothly
Except one in
TestACElectricityBus.test_benchmark_AB_grid_pvwhere it is a type mismatch which leads the two timeseries to not equal (one is int64, whereas the other float64) --> easily fixable. I would therefore suggest we use the latest panda version again.Changes proposed in this pull request:
The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)For more information on how to contribute check the CONTRIBUTING.md.