Skip to content

Sort out dependencies in requirements.txt#840

Merged
smartie2076 merged 4 commits intodevfrom
fix/dependencies
Mar 25, 2021
Merged

Sort out dependencies in requirements.txt#840
smartie2076 merged 4 commits intodevfrom
fix/dependencies

Conversation

@Bachibouzouk
Copy link
Copy Markdown
Collaborator

@Bachibouzouk Bachibouzouk commented Mar 24, 2021

Fix #836, fix #760, fix #200

I tried python 3.8 and 3.9, I let install the latest panda version (v1.2.3, .. happen only once ^^) and all the tests ran smoothly
Except one in TestACElectricityBus.test_benchmark_AB_grid_pv where it is a type mismatch which leads the two timeseries to not equal (one is int64, whereas the other float64) --> easily fixable. I would therefore suggest we use the latest panda version again.

Changes proposed in this pull request:

  • Forbid pyomo v 5.7.3
  • add plotly to the default to generate pngs

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

For more information on how to contribute check the CONTRIBUTING.md.

Copy link
Copy Markdown
Collaborator

@smartie2076 smartie2076 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, then we should use the most recent pandas version! Wonder why we did not use it before, then.

@smartie2076 smartie2076 merged commit edc76d0 into dev Mar 25, 2021
@smartie2076 smartie2076 deleted the fix/dependencies branch March 25, 2021 14:39
@smartie2076 smartie2076 mentioned this pull request May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants