Add check for correct installedcap processing to AB_grid_pv benchmark… by SabineHaas · Pull Request #831 · rl-institut/multi-vector-simulator

SabineHaas · 2021-03-17T08:15:42Z

Address #825

Changes proposed in this pull request:

Add check for correct installedCap processing to AB_grid_pv benchmark test

@smartie2076 I realized too late that this check should actually be done in another benchmark test, as in AB_grid_pv the capacity is not optimized.

I quickly checked, that the test passes as well for an optimized capacity (optimizedCap=True and very low feed-in tariff to get simulation to run). So the question is answered but we might want to add the test in another benchmark test.

We can decide whether we still would like to merge this PR as it is an additional check.

The following steps were realized, as well (if applies):

Use in-line comments to explain your code
❌ Write docstrings to your code (example docstring)
❌ For new functionalities: Explain in readthedocs
❌ Write test(s) for your new patch of code (pytests, assertion debug messages)
Update the CHANGELOG.md
Apply black (black . --exclude docs/)
Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

====================================================================================================================== short test summary info =======================================================================================================================
FAILED tests/test_input_folder_parameters.py::test_input_folder_csv_files_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/build/lib/multi_vector_simulator/package_data/input_template] - AssertionError: 
FAILED tests/test_input_folder_parameters.py::test_input_folder_csv_files_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/src/multi_vector_simulator/package_data/input_template] - AssertionError: 
FAILED tests/test_input_folder_parameters.py::test_input_folder_json_file_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/build/lib/multi_vector_simulator/package_data/inputs] - AssertionError: In path /home/sab...
FAILED tests/test_input_folder_parameters.py::test_input_folder_json_file_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/src/multi_vector_simulator/package_data/inputs] - AssertionError: In path /home/sabine/vi...
================================================================================================= 4 failed, 386 passed, 2 skipped, 77 warnings in 100.42s (0:01:40) ==================================================================================================

Ready for review @smartie2076

Please mark above checkboxes as following:

Open
Done

❌ Check not applicable to this PR

_{For more information on how to contribute check the CONTRIBUTING.md.}

… test

smartie2076

I feel like this is actually the correct point to add the benchmark test. I would merge it either way.

CHANGELOG.md

tests/test_benchmark_scenarios.py

smartie2076 · 2021-03-18T13:13:42Z

tests/test_benchmark_scenarios.py

+        # adapt index
+        result_time_series_pv.index = input_time_series_pv_shortened.index
+
+        assert_series_equal(


assert_series_equal seems very handy :)

Maybe import is as pd.assert_series_equal so that it is clear that it comes from pd?

It's from pandas.util.testing so it would be a bit long pd.util.testing.assert_series_equal..

…id_PV

Co-authored-by: smartie2076 <no-reply>

Co-authored-by: smartie2076 <[email protected]>

…-institut/multi-vector-simulator into feature/check_installedcap_processing

SabineHaas · 2021-03-22T08:49:38Z

===================================================================================================================== short test summary info =====================================================================================================================
FAILED tests/test_input_folder_parameters.py::test_input_folder_csv_files_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/build/lib/multi_vector_simulator/package_data/input_template] - AssertionError: 
FAILED tests/test_input_folder_parameters.py::test_input_folder_csv_files_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/src/multi_vector_simulator/package_data/input_template] - AssertionError: 
FAILED tests/test_input_folder_parameters.py::test_input_folder_json_file_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/build/lib/multi_vector_simulator/package_data/inputs] - AssertionError: In path /home/...
FAILED tests/test_input_folder_parameters.py::test_input_folder_json_file_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/src/multi_vector_simulator/package_data/inputs] - AssertionError: In path /home/sabine...
================================================================================================ 4 failed, 386 passed, 2 skipped, 77 warnings in 98.70s (0:01:38) =================================================================================================

smartie2076 · 2021-03-22T09:25:53Z

===================================================================================================================== short test summary info =====================================================================================================================
FAILED tests/test_input_folder_parameters.py::test_input_folder_csv_files_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/build/lib/multi_vector_simulator/package_data/input_template] - AssertionError: 
FAILED tests/test_input_folder_parameters.py::test_input_folder_csv_files_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/src/multi_vector_simulator/package_data/input_template] - AssertionError: 
FAILED tests/test_input_folder_parameters.py::test_input_folder_json_file_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/build/lib/multi_vector_simulator/package_data/inputs] - AssertionError: In path /home/...
FAILED tests/test_input_folder_parameters.py::test_input_folder_json_file_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/src/multi_vector_simulator/package_data/inputs] - AssertionError: In path /home/sabine...
================================================================================================ 4 failed, 386 passed, 2 skipped, 77 warnings in 98.70s (0:01:38) =================================================================================================

Can you explain to me what those error messages are and whether they should worry me?

SabineHaas · 2021-03-22T09:53:23Z

===================================================================================================================== short test summary info =====================================================================================================================
FAILED tests/test_input_folder_parameters.py::test_input_folder_csv_files_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/build/lib/multi_vector_simulator/package_data/input_template] - AssertionError: 
FAILED tests/test_input_folder_parameters.py::test_input_folder_csv_files_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/src/multi_vector_simulator/package_data/input_template] - AssertionError: 
FAILED tests/test_input_folder_parameters.py::test_input_folder_json_file_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/build/lib/multi_vector_simulator/package_data/inputs] - AssertionError: In path /home/...
FAILED tests/test_input_folder_parameters.py::test_input_folder_json_file_have_required_parameters[/home/sabine/virtualenvs/multi_vector_simulator/multi-vector-simulator/src/multi_vector_simulator/package_data/inputs] - AssertionError: In path /home/sabine...
================================================================================================ 4 failed, 386 passed, 2 skipped, 77 warnings in 98.70s (0:01:38) =================================================================================================

Can you explain to me what those error messages are and whether they should worry me?

It's been like that for a long time - I had mentioned that in another PR. Seems like in package_data there are wrong parameters.. maybe this is because I did not newly install MVS in this project (build directory)? On the other hand, also in src/.../package_data this happens. @Bachibouzouk do you know whether this is due to not updating MVS installation?

@smartie2076 nothing to worry for PR merging to my mind

Bachibouzouk · 2021-03-22T11:02:55Z

@Bachibouzouk do you know whether this is due to not updating MVS installation?

Yes it is likely due to not updating MVS locally :)

SabineHaas · 2021-03-22T11:27:20Z

@Bachibouzouk do you know whether this is due to not updating MVS installation?

Yes it is likely due to not updating MVS locally :)

thanks @Bachibouzouk - will do that before next PR

Add check for correct installedcap processing to AB_grid_pv benchmark…

85afeb0

… test

SabineHaas self-assigned this Mar 17, 2021

update changelog

0a800d6

SabineHaas requested a review from smartie2076 March 17, 2021 08:21

SabineHaas mentioned this pull request Mar 17, 2021

Faulty error message when installedCap of an energyProduction asset equal to maximumCap #825

Open

Apply black

e274b3c

SabineHaas mentioned this pull request Mar 18, 2021

Add benchmarktest for maximumCap constraint and adapt maximumCap usage #830

Closed

smartie2076 approved these changes Mar 18, 2021

View reviewed changes

SabineHaas and others added 7 commits March 22, 2021 09:21

Check that total generaton is used to cover demand in benchmark AB_gr…

5af2d6c

…id_PV

Suggestion from code review

4fd7659

Co-authored-by: smartie2076 <no-reply>

Add info to docstring

403ec95

Apply suggestions from code review

ea5205d

Co-authored-by: smartie2076 <[email protected]>

update changelog

4666a41

apply black

ef50ac6

Merge branch 'feature/check_installedcap_processing' of github.com:rl…

c0deed5

…-institut/multi-vector-simulator into feature/check_installedcap_processing

SabineHaas merged commit ee50887 into dev Mar 22, 2021

SabineHaas deleted the feature/check_installedcap_processing branch March 22, 2021 08:49

smartie2076 mentioned this pull request May 31, 2021

Release/v1.0.0 #898

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add check for correct installedcap processing to AB_grid_pv benchmark…#831

Add check for correct installedcap processing to AB_grid_pv benchmark…#831
SabineHaas merged 10 commits intodevfrom
feature/check_installedcap_processing

SabineHaas commented Mar 17, 2021 •

edited

Loading

Uh oh!

smartie2076 left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smartie2076 Mar 18, 2021

Uh oh!

SabineHaas Mar 22, 2021

Uh oh!

SabineHaas commented Mar 22, 2021

Uh oh!

smartie2076 commented Mar 22, 2021

Uh oh!

SabineHaas commented Mar 22, 2021

Uh oh!

Bachibouzouk commented Mar 22, 2021

Uh oh!

SabineHaas commented Mar 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

SabineHaas commented Mar 17, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

smartie2076 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

smartie2076 Mar 18, 2021

Choose a reason for hiding this comment

Uh oh!

SabineHaas Mar 22, 2021

Choose a reason for hiding this comment

Uh oh!

SabineHaas commented Mar 22, 2021

Uh oh!

smartie2076 commented Mar 22, 2021

Uh oh!

SabineHaas commented Mar 22, 2021

Uh oh!

Bachibouzouk commented Mar 22, 2021

Uh oh!

SabineHaas commented Mar 22, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

SabineHaas commented Mar 17, 2021 •

edited

Loading