Conversation
Ask to first test package locally, then upload rc on pypi.org, then release on master, then official release on pypi.org
There was a problem hiding this comment.
Thanks for reworking @Bachibouzouk :)
I guess one has to do another release with this protocol and check whether everything works fine.
I suggest that @smartie2076 should give her "go", as well before you merge.
CONTRIBUTING.md
Outdated
| ``` | ||
| 6. Create a new empty folder | ||
| ```bash | ||
| mkdir empty_folder |
There was a problem hiding this comment.
Why do you need this empty_folder if you do not use it as output folder?
There was a problem hiding this comment.
To make sure you don't already have a default output folder in there and also to make sure none of the .py are within your path (i.e. you make sure you load the code from the package location, not from your current directory)
There was a problem hiding this comment.
I think if duplication in 5 and 6 is intentional, a sentence should be there that explains that it is so, because I would have skipped 6
CONTRIBUTING.md
Outdated
| ``` | ||
| 9. Create a new empty folder | ||
| ```bash | ||
| mkdir empty_folder |
Co-authored-by: Sabine Haas <[email protected]>
This is the protocol which was followed during the last release (I used our experience to rewrite this protocol) |
Ah so have you written it before and then followed it? |
Not exactly, I wrote it as we were doing a release not following the previous protocol |
CONTRIBUTING.md
Outdated
| ``` | ||
| 6. Create a new empty folder | ||
| ```bash | ||
| mkdir empty_folder |
There was a problem hiding this comment.
I think if duplication in 5 and 6 is intentional, a sentence should be there that explains that it is so, because I would have skipped 6
| Checking dist/multi_vector_simulator-X.Y.Zrci-py3-none-any.whl: PASSED | ||
| Checking dist/multi-vector-simulator-X.Y.Zrci.tar.gz: PASSED | ||
| ``` | ||
| If one of the two is not `PASSED`, find out why and fix it. |
There was a problem hiding this comment.
How do we fix things - we did not create a release branch jet, so I suppose we are fixing by fixing the dev branch? Maybe make it explicit that those fixes should be merged into dev first?
Co-authored-by: smartie2076 <[email protected]>
3 participants
Fix #694
Changes proposed in this pull request:
Ask to first test package locally, then upload rc on pypi.org, then release on master, then official release on pypi.org
The following steps were realized, as well (if applies):
For more information on how to contribute check the CONTRIBUTING.md.