Conversation
|
@SabineHaas I did not run the pytests for everything yet, but it is ready for review. What do you think in general about rounding the oemof results? Is this something acceptable? @TheOneAndra FYI. Can you read though the |
Bachibouzouk
left a comment
There was a problem hiding this comment.
In the text replace lower/smaller then by lower/smaller than
Not completely done reviewing, but Ive got meetings so I'll finish later
SabineHaas
left a comment
There was a problem hiding this comment.
@SabineHaas I did not run the pytests for everything yet, but it is ready for review. What do you think in general about rounding the oemof results? Is this something acceptable?
Yes, I understand the problem and find the rounding acceptable.
- Write function both for scalar values as well as for pd.Series. This evaluates all negative values and rounds the positive values below the threshold. - Call the function when reading the decision variables for capacities and dispatch from the oemof results (changes `E1.get_storage_results()`, `E1.get_flow` and `E1.get_optimal_cap`
Co-authored-by: Pierre Francois <[email protected]> Co-authored-by: Sabine Haas <[email protected]>
6e4483f to
6f57ae6
Compare
|
I ran |
Fix #523
Fix #768
We had issues with the SOC being out of bounds with [0,1] and marginal negative flows. This PR fixes both issues. The marginal negative flows are rounded to 0 (threshold: -10^-6), large negative values raise a warning and are unchanged. Marginal positive flows (reason for SOC out of bounds) are also rounded to 0.
Compared to SOC in #768, you can see that in the now created simulation_report.pdf the SOC is always 0.
Changes proposed in this pull request:
[x] Add precision issue in RTD
[x] Function
E1.cut_below_picoto round decision variables (capacities, flows) below threshold of plus/minus 10^-6 to 0, add warnings if negative value larger then threshold (invalid result). Includes pytests (#)[x] Call
E1.cut_below_picoinE1.get_flows,E1.get_optimal_capandE1.get_storage_results(#)The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)