Skip to content

Feature/degree of nze#776

Merged
SabineHaas merged 14 commits intodevfrom
feature/degree_of_nze
Feb 11, 2021
Merged

Feature/degree of nze#776
SabineHaas merged 14 commits intodevfrom
feature/degree_of_nze

Conversation

@SabineHaas
Copy link
Copy Markdown
Contributor

@SabineHaas SabineHaas commented Jan 27, 2021

Fix #773

Changes proposed in this pull request:

  • Added net zero energy KPI degree of NZE with E3.equation_degree_of_net_zero_energy() and E3.add_degree_of_net_zero_energy()
  • Added tests for E3.equation_degree_of_net_zero_energy() and E3.add_degree_of_net_zero_energy()
  • Added information about degree of NZE to RTD

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@SabineHaas SabineHaas self-assigned this Jan 27, 2021
@SabineHaas SabineHaas marked this pull request as ready for review February 2, 2021 09:46
@SabineHaas
Copy link
Copy Markdown
Contributor Author

@smartie2076 TOTAL_RENEWABLE_GENERATION_IN_LES is already in eleq, right? It's used in the other KPI, as well, but I wanted to be sure.

Copy link
Copy Markdown
Collaborator

@smartie2076 smartie2076 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick :)

TOTAL_RENEWABLE_GENERATION_IN_LES should be in eleq.

I think NZE is a bit to short of an abbrevation for Degree of Net Zero Energy, as I always skip "degree" then...

@SabineHaas
Copy link
Copy Markdown
Contributor Author

SabineHaas commented Feb 11, 2021

I'll merge now as tests pass locally.
As you can see from execute_tests_on_master.txt I only got errors because of wrong parameters in the package_data and build directory. So, nothing, I have pushed.

@SabineHaas SabineHaas merged commit c920eaa into dev Feb 11, 2021
@SabineHaas SabineHaas deleted the feature/degree_of_nze branch February 11, 2021 09:14
@SabineHaas SabineHaas mentioned this pull request Feb 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add KPI: degree of NZE

2 participants