Skip to content

Bugfix in autoreport#770

Merged
Bachibouzouk merged 9 commits intodevfrom
fix/autoreport
Jan 22, 2021
Merged

Bugfix in autoreport#770
Bachibouzouk merged 9 commits intodevfrom
fix/autoreport

Conversation

@Bachibouzouk
Copy link
Copy Markdown
Collaborator

@Bachibouzouk Bachibouzouk commented Jan 21, 2021

Fix #769, fix #763, fix #756

Changes proposed in this pull request:

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

For more information on how to contribute check the CONTRIBUTING.md.

Bachibouzouk added 3 commits January 21, 2021 19:24
Distinguish between older case where the kpi
dict_values[KPI[KPI_UNCOUPLED_DICT] is a dict and
newer case where it is a DataFrame
@Bachibouzouk Bachibouzouk changed the title Fix/autoreport Bugfix in autoreport Jan 21, 2021
Bachibouzouk added 6 commits January 21, 2021 19:59
This reloads the content of dash app if a change in module F2
is detected, allowing live modification of the report
layout
- only regenerate maps of location if the files are missing
@Bachibouzouk Bachibouzouk marked this pull request as ready for review January 22, 2021 09:47
Copy link
Copy Markdown
Collaborator

@TheOneAndra TheOneAndra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all good

@Bachibouzouk Bachibouzouk merged commit 85657b0 into dev Jan 22, 2021
@Bachibouzouk Bachibouzouk deleted the fix/autoreport branch January 22, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mvs_report terminates before printing a report [Bug] Report empty table Problems when trying to simulate without internet connection

2 participants