Conversation
|
A test is failing, I still need to fix it |
| # Format KPI about energy generation into a pd.DataFrame | ||
| dict_values[KPI][KPI_UNCOUPLED_DICT] = pd.DataFrame.from_dict( | ||
| dict_values[KPI][KPI_UNCOUPLED_DICT], orient="index" | ||
| ) | ||
|
|
There was a problem hiding this comment.
Is this a workaround for the EPA, or does this mean that we will keep adding parameters to the KPI_UNCOUPLED_DICT as we were, and soley reformat it so that it is easier to use in the report?
Does this fix how the values are printed in the excel-sheet?
There was a problem hiding this comment.
It is no workaround, it makes a pd.DF from the way we were adding the parameters (it does it at the very end of the E0 function. It does print it nicely, in the report, and in the xls sheet. The EPA parser will be done in #675 after rebasing on dev after merging this PR :)
| "This results in the following KPI of the dispatch per energy sector:" | ||
| ), | ||
| # TODO the table with renewable share, emissions, total renewable generation, etc. | ||
| make_dash_data_table(df_kpi_sectors), |
There was a problem hiding this comment.
I would move the table to the end of the report, below Energy System: Key Performance Indicators (KPIs) and the energy system wide KPI.
However, it does not really matter... the order of the report is a mess and should probably be changed. Probably
- Project and economic data
- Energy system plot
- KPI
- Costs
- Dispatch
- Assumptions (including resources, demands...)
would make more sense...
There was a problem hiding this comment.
I would say, whoever wants to reschuffle the order of the report can do it now in a subsequent PR :)
2 participants
Addresses part of #703
Changes proposed in this pull request:
pd.DataFrameThe following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)For more information on how to contribute check the CONTRIBUTING.md.