Conversation
| - | ||
| ### Changed | ||
| - | ||
| - fix xlrd to xlrd==1.2.0 in requirements/default.txt (#716) |
There was a problem hiding this comment.
maybe you can add a hint on the reason which lead to freezing the version number?
There was a problem hiding this comment.
xlrd has explicitly removed support for anything other than xls files.
https://stackoverflow.com/questions/65254535/xlrd-biffh-xlrderror-excel-xlsx-file-not-supported
When reading the xlsx files saved by mvs we get an error without the version downgrade because panda is using xlrd by default. This does not show within mvs, because you are not reading the xlsx files, but might for other users.
Another possibility would of course be to change the type to xls, but I guess that's a bigger task.
There was a problem hiding this comment.
I meant hint in the changelog entry :) so that someone reading this in 4 month and wondering why we frooze the version gets an answer immediately. Don't worry, I'll add it in my next PR if I don't forget :)
There was a problem hiding this comment.
ah ok, didn't gat that ;)
Add description from PR #744
2 participants
Fix #716
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.