DA definition#730
Conversation
- Define `D2.constraint_minimal_degree_of_autonomy` - Change `D2.add_constraints`
In MVS_parameters.rst
mahendrark
force-pushed
the
feature/minimal_degree_of_autonomy
branch
2 times, most recently
from
e674bfe to
834c8cd
Compare
|
@mahendrark Would have been easier that you wait for this branch to be merged into |
Is there a problem? What happens in parent branch should typically not affect the child branch, except for merge conflicts. |
Hmhm, I am also confused now why there are so many changes compared to the original PR #726... I would have guessed that @TheOneAndras changes only affect few files, especially not the @TheOneAndra: Please remove |
smartie2076
left a comment
smartie2076
left a comment
There was a problem hiding this comment.
I think the formula should be adapted. Does it still work, then?
I am not sure why you have so many commits (from my branch, nonetheless) - this would probably be a good case for a rebase onto my current branch feature/minimal_degree_of_autonomy.
smartie2076
left a comment
smartie2076
left a comment
There was a problem hiding this comment.
Also, there should be a changelog entry that you changed the DA definition in the RTD, and that you changed some rtd data to include the min DA as well.
apply @smartie2076 comment for the changelog
Co-authored-by: smartie2076 <[email protected]>
3 participants
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.