Conversation
|
@TheOneAndra can you check the description of the feature in the RTD? To make sure we are on the same page. Also, please create a PR into this one to adapt the DOA definition in the RTD to our current one. |
|
@SabineHaas you can also look at this PR, if you are interested. Not done, though. |
1c527a6 to
bd48576
Compare
Check PR #730 |
So for now one cannot simulate two energy providers with different minimal_DA. This would be an interesting disctinction for energy cells. I added that comment in issue #721 |
e674bfe to
834c8cd
Compare
|
I did some housekeeping here :) @smartie2076 @TheOneAndra please do a |
Hi @mahendrark! I appreciate the housekeeping, but especially for |
@mahendrark, I am pretty sure I was refering to rebasing on your own branch, when you are sure no one else works on it ... |
TheOneAndra
left a comment
There was a problem hiding this comment.
@smartie2076 Here are the changes we discussed together.
452a05f to
7e89a14
Compare
SabineHaas
left a comment
There was a problem hiding this comment.
Wow, this was a big PR @smartie2076 ! :D but nice features!
general comments:
- you could add tests for E3 functions
- solve merge conflict (you already told me that this is on your list)
I actually liked the old definition of DoA, which was in other words a "degree of Net Zero Energy", as we need this for pvcompare.
It would be nice if we could preserve the KPI, i.e. the old definition of DoA (functions were all there) and just rename it to "degree of net zero energy". What do you think?
smartie2076
left a comment
There was a problem hiding this comment.
Nice, that wasnt too much change :D
- Update definition of degree of autonomy and change equation: Now based on demand and consumption from energy provider only - Add parameter `minimal_degree_of_autonomy` into `MVS_parameters_list.csv` and reference it - Add description of minimal degree of autonomy constraint
- Add `TOTAL_CONSUMPTION_FROM_PROVIDERS` to `constants_json_strings.py` - Missing: add_total_consumption_electricity_equivalent()
- Change constants in `E3.add_total_feedin_electricity_equivaluent` so that they are logical - Refactor `E3.add_total_feedin_electricity_equivaluent` to `E3.add_total_feedin_electricity_equivaluent`
- Add `MINIMAL_DEGREE_OF_AUTONOMY` to `constants_json_strings.py` - Add `MINIMAL_DEGREE_OF_AUTONOMY` to `KNOWN_EXTRA_PARAMETERS` in `constants.py` - Change `D2.add_constraints` to call new constraint - Add `D2.constraint_minimal_degree_of_autonomy` with processing function `D2.prepare_constraint_minimal_degree_of_autonomy` - Add pytest for `D2.prepare_constraint_minimal_degree_of_autonomy` - Missing: Test for `D2.constraint_minimal_degree_of_autonomy` -> @mahendrak?
- Update `input_template` - Update all files `constraints.csv` in `tests/benchmark_test_inputs` - Update `tests/test_data/inputs_for_E1/csv_elements/constraints.csv` - Update `tests/inputs/constraints.csv`, and adapt `maximum_emissions` so that both constraints can coexist - Update `tests/inputs/mvs_config.json` with the `json_processed.json` from the `test/inputs` folder - Update json files for D0 and D1 tests: `test/test_data/inputs_for_D0/mvs_config.json` and `test/test_data/inputs_for_D1/mvs_config.json`
- Now based on demand and consumption from energy provider (see RTD) - Added pytest for functions
- Generalize `E4.minimal_renewable_share_test` to `E4.minimal_constraint_test` - Test both minimal renewable share as well as minimal degree of autonomy with that function - Update pytest for generic function
- Verification applied not only to renewable assets, but specifically to dispatchable assets (otherwise there is an error message with the `mvs_config.json` file, as the automatically defined DSO consumption source does not have the parameter `renewableAsset` - Adapt pytest
- Add benchmark test, analogeous to benchmark test for minimal renewable share constraint - Add input files for a case with 0% minimal degree of autonomy and one with 70% minimal degree of autonomy
- Fix RTD math environment - Remove unnecessary code (for `E4.maximum_emissions_test`) - Add instructions for pytest for model constraints introduced in `D2`
- Remove automatically generated assets (excess, feedin) from energyConsumption in `mvs_config.json` files, as they do not have a `dsm` nor `type_asset` parameter, resulting in an error. Created issue for permanent fix - Take new minimal DOA constraint into account for `D2` pytests
…ider: - Refactor `E3.add_total_consumption_electricity_equivaluent()` to `E3.add_total_consumption_from_provider_electricity_equivalent()` - Add pytest - Update changelog accordingly
d8e0814 to
e6862a8
Compare
|
@SabineHaas: I think I am done (also added a pytest for E3), and when the tests ran though I can merge. @TheOneAndra: The branch does calculate the consumption from energy providers, and places the info into the @Bachibouzouk added |
Co-authored-by: Sabine Haas <[email protected]>
Fix #721
Changes proposed in this pull request:
D2.constraint_minimal_degree_of_autonomy()D2.constraint_minimal_degree_of_autonomy(), specifically only forD2.prepare_constraint_minimal_degree_of_autonomy. See Add tests for adding minimal_renewable_share #742 if this is also possible for the general function.E4.minimal_degree_of_autonomy()E4.minimal_degree_of_autonomy()The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.