Fix/c0 storage time series review#723
Conversation
- Exception needs to be tested - Changed `energyStorage.csv` - Added `storage_1.csv` - Added column in `parameter_timeseries`
| - Changed `C0.energyStorage()` for timeseries in storage parameters (hotfix) (#720) | ||
| - Input files and benchmark test `test_benchmark_special_features.Test_Parameter_Parsing()`: Now also including timeseries in a storage component () |
There was a problem hiding this comment.
Hi @MaGering !
"In your PR, please also add the correct number for the benchmark tests changelog entry."
Refers to the lines above. I added changelog entries for what you changed, where I also put your PR as origin (#720). Line 38 is what I changed in this PR (#723). As I can not know what the PR number is when I am working on my lokal branch, I couldnt assign the number to the changelog entry. Please add the number in the brackets ;)
There was a problem hiding this comment.
You can change this either locally, or by opening the file view of the changelog in github, making a manual change, and submitting it.
MaGering
left a comment
MaGering
left a comment
There was a problem hiding this comment.
Looks good to me! The benchmark test ran without error as I checked it locally. Only test_benchmark_special_features.py needs to be reformatted with black and conflicts with CHANGELOG.md resolved.
Nice! As you are merging into a PR and not into |
2 participants
Here are my adaptations. I did neither do a linting test with black nor executed all pytests - so please do that before you request a new review for your PR #720.
In your PR, please also add the correct number for the benchmark tests changelog entry.