Merged
Conversation
TheOneAndra
commented
Dec 11, 2020
| 43, None, The type of the component., demand, *demand*, str, None,type_asset,typeasset-label | ||
| 44, None," Input the type of OEMOF component. For example, a PV plant would be a source, a solar inverter would be a transformer, etc. The `type_oemof` will later on be determined through the EPA.", sink, *sink* or *source* or one of the other component classes of OEMOF., str, None,type_oemof,typeoemof-label | ||
| 45, None, Unit associated with the capacity of the component.," Storage could have units like kW or kWh, transformer station could have kVA, and so on.", Appropriate scientific unit, str, NA,unit,unit-label | ||
| 30, None, User can enter True if the asset is considered as a renewable energy source. False should be entered otherwise., True, Acceptable values are either True or False, str, Boolean,renewableAsset,renewableasset-label |
Collaborator
Author
There was a problem hiding this comment.
@smartie2076
Please double check my def
smartie2076
approved these changes
Dec 14, 2020
Collaborator
smartie2076
left a comment
There was a problem hiding this comment.
Thanks @TheOneAndra! I added a changelog entry and will proceed to merge it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.