Skip to content

Fix/plots issue 444 review#684

Merged
SabineHaas merged 5 commits intofix/plots_issue_444from
fix/plots_issue_444_review
Dec 5, 2020
Merged

Fix/plots issue 444 review#684
SabineHaas merged 5 commits intofix/plots_issue_444from
fix/plots_issue_444_review

Conversation

@smartie2076
Copy link
Copy Markdown
Collaborator

@smartie2076 smartie2076 commented Dec 4, 2020

This PR adresses minor issues with #666 and also will c-l-o-s-e #683 (@SabineHaas please add this to your first post in #666).

Changes proposed in this pull request:

  • Constant variables used
  • Adapt tests/inputs so that storage is used

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

@smartie2076 smartie2076 added the bug Something isn't working label Dec 4, 2020
@smartie2076 smartie2076 self-assigned this Dec 4, 2020
@SabineHaas SabineHaas merged commit 6c6bef0 into fix/plots_issue_444 Dec 5, 2020
@SabineHaas SabineHaas deleted the fix/plots_issue_444_review branch December 5, 2020 14:23
@SabineHaas SabineHaas mentioned this pull request Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants