efficiency of storage_capacity in storage_xx.csvnow actually displays the storages' efficiency/ability to hold charge over time#676
Merged
SabineHaas merged 14 commits intodevfrom Dec 5, 2020
Conversation
…y/ability to hold charge over time in RTD
…and inputs to 1-value
16 tasks
Contributor
Author
|
|
Collaborator
did you create this PR recently? I wonder why github action did not start ... |
Contributor
Author
yes, today |
Collaborator
|
I made a hotfix on dev, if you merge or rebase it onto this branch it should trigger the github action |
smartie2076
approved these changes
Dec 4, 2020
Collaborator
smartie2076
left a comment
There was a problem hiding this comment.
Can you add an error message if the efficiency of storage capacity is 0 and a warning if the efficiency is < 0.2? That will help users that already use the MVS to spot this major change when using old files.
smartie2076
reviewed
Dec 4, 2020
Co-authored-by: smartie2076 <[email protected]>
Co-authored-by: smartie2076 <[email protected]>
Co-authored-by: smartie2076 <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #295
Changes proposed in this pull request:
loss_rateof storages inD1defined as1-efficiencyinstead of asefficiencyof the storage capacity (seestorage_xx.csvfiles)efficiencyofstorage_capacityinstorage_xx.csvnow actually is defined as the storages' efficiency/ability to hold charge over timeefficiencyofstorage_capacityin all provided benchmark tests and inputs to1-valueefficiencyofstorage_capacityas actual efficiency/ability to hold charge over time in RTDThe following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.