Skip to content

efficiency of storage_capacity in storage_xx.csvnow actually displays the storages' efficiency/ability to hold charge over time#676

Merged
SabineHaas merged 14 commits intodevfrom
fix/storage_losses_vs_efficiency
Dec 5, 2020
Merged

efficiency of storage_capacity in storage_xx.csvnow actually displays the storages' efficiency/ability to hold charge over time#676
SabineHaas merged 14 commits intodevfrom
fix/storage_losses_vs_efficiency

Conversation

@SabineHaas
Copy link
Copy Markdown
Contributor

@SabineHaas SabineHaas commented Dec 2, 2020

Fix #295

Changes proposed in this pull request:

  • loss_rate of storages in D1 defined as 1-efficiency instead of as efficiency of the storage capacity (see storage_xx.csv files)
  • efficiency of storage_capacity in storage_xx.csvnow actually is defined as the storages' efficiency/ability to hold charge over time
  • Adapted efficiency of storage_capacity in all provided benchmark tests and inputs to 1-value
  • Documented the change of efficiency of storage_capacity as actual efficiency/ability to hold charge over time in RTD
  • Added a error message if the efficiency of storage capacity is 0 and logging.warning if the efficiency is < 0.2, to help users to spot major change when using old files

The following steps were realized, as well (if applies):

  • ❌ Use in-line comments to explain your code
  • ❌ Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • ❌ Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@SabineHaas
Copy link
Copy Markdown
Contributor Author

EXECUTE_TESTS_ON=master pytest has passed

@SabineHaas SabineHaas marked this pull request as ready for review December 2, 2020 15:51
@Bachibouzouk
Copy link
Copy Markdown
Collaborator

EXECUTE_TESTS_ON=master pytest has passed

did you create this PR recently? I wonder why github action did not start ...

@SabineHaas
Copy link
Copy Markdown
Contributor Author

EXECUTE_TESTS_ON=master pytest has passed

did you create this PR recently? I wonder why github action did not start ...

yes, today

@Bachibouzouk
Copy link
Copy Markdown
Collaborator

I made a hotfix on dev, if you merge or rebase it onto this branch it should trigger the github action

Copy link
Copy Markdown
Collaborator

@smartie2076 smartie2076 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add an error message if the efficiency of storage capacity is 0 and a warning if the efficiency is < 0.2? That will help users that already use the MVS to spot this major change when using old files.

SabineHaas and others added 3 commits December 5, 2020 15:28
Co-authored-by: smartie2076 <[email protected]>
Co-authored-by: smartie2076 <[email protected]>
Co-authored-by: smartie2076 <[email protected]>
@SabineHaas SabineHaas self-assigned this Dec 5, 2020
@SabineHaas SabineHaas merged commit 490bb79 into dev Dec 5, 2020
@SabineHaas SabineHaas deleted the fix/storage_losses_vs_efficiency branch December 5, 2020 16:14
@SabineHaas SabineHaas mentioned this pull request Dec 8, 2020
@smartie2076 smartie2076 mentioned this pull request Jan 11, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[On hold][Bug] storage_01.csv mislabeled "efficiency" for storage capacity

3 participants