Renewable factor and renewable share of local generation#637
Merged
smartie2076 merged 28 commits intodevfrom Nov 11, 2020
Merged
Renewable factor and renewable share of local generation#637smartie2076 merged 28 commits intodevfrom
smartie2076 merged 28 commits intodevfrom
Conversation
…add_total_renewable_and_non_renewable_energy_origin` And `E3.renewable_share` to `E3.add_renewable_factor`
…ctor constraint` in all files (python, messages, RTD, json, tests, csv), so that this is in line with the definition and does not cause any confusion.
…_local_generation
beb7ad3 to
2fa9ec6
Compare
Collaborator
Author
|
@SabineHaas @Bachibouzouk I now did a mini-rebase of this PR, I hope that helps a bit with the review. Whats left is to adapt one or two benchmark tests so that they also test the functionality of the KPI. |
Bachibouzouk
approved these changes
Nov 10, 2020
Collaborator
Bachibouzouk
left a comment
There was a problem hiding this comment.
I spotted a few typos. I made a few recommendations as well, you can apply them if you agree to them
…ulator into feature/energy_busses # Conflicts: # CHANGELOG.md
smartie2076
commented
Nov 11, 2020
Collaborator
Author
smartie2076
left a comment
There was a problem hiding this comment.
Adressing comments that can be solved online
Co-authored-by: Pierre Francois <[email protected]>
…newable_share_mini # Conflicts: # CHANGELOG.md
Merged
16 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #636
Changes proposed in this pull request:
Renewable share of local generation(d099dec)❌ RTD: Introduce
Share of demand supplied by renewables(see argument made in Renewable share calculation can be misleading #636)Renewable factor(d099dec)Renewable share of local generationin a seperate functionRenewable sharewith energy carrier weightingThe following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.