Skip to content

Fix issue with report generation in develop install#632

Merged
mahendrark merged 2 commits intodevfrom
fix/report-as-developper
Nov 4, 2020
Merged

Fix issue with report generation in develop install#632
mahendrark merged 2 commits intodevfrom
fix/report-as-developper

Conversation

@Bachibouzouk
Copy link
Copy Markdown
Collaborator

@Bachibouzouk Bachibouzouk commented Nov 4, 2020

Fix #631

python setup.py develop
followed by
mvs_tool -i tests/inputs/ -ext csv -f -pdf
should work now

previously only worked via normal pip install or python setup.py install

Changes proposed in this pull request:

  • If assets folder is not found in package look in current folder for report/assets folder

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

For more information on how to contribute check the CONTRIBUTING.md.

Bachibouzouk added 2 commits November 4, 2020 14:30
This is the case when working with package installed via
"python setup.py develop", not when the package is installed
via pip or "python setup.py install"
@mahendrark mahendrark merged commit bf1cbdf into dev Nov 4, 2020
@mahendrark mahendrark deleted the fix/report-as-developper branch November 4, 2020 13:54
@smartie2076 smartie2076 mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Error when trying to generate the report of the simulation

2 participants