Model equations - minor changes#627
Merged
smartie2076 merged 7 commits intoModel_equationsfrom Nov 5, 2020
Merged
Conversation
Collaborator
Author
|
@ursulaelmir I propose some small changes to your PR #581. Please let me know if you want to check what I did, otherwise I would merge this into your PR by the end of the week. |
ursulaelmir
reviewed
Nov 4, 2020
ursulaelmir
reviewed
Nov 4, 2020
ursulaelmir
reviewed
Nov 4, 2020
ursulaelmir
reviewed
Nov 4, 2020
ursulaelmir
reviewed
Nov 4, 2020
ursulaelmir
reviewed
Nov 4, 2020
ursulaelmir
reviewed
Nov 4, 2020
ursulaelmir
reviewed
Nov 4, 2020
ursulaelmir
reviewed
Nov 4, 2020
ursulaelmir
reviewed
Nov 4, 2020
Collaborator
welcome back @smartie2076 :) I reviewed your changes and also proposed some minor ones as I read the readthedocs page |
Collaborator
Author
|
Thanks @ursulaelmir! I fixed your comments in the latest commit. Will merge it into your PR now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #Issue
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.