Skip to content

Model equations - minor changes#627

Merged
smartie2076 merged 7 commits intoModel_equationsfrom
Model_equations_minor
Nov 5, 2020
Merged

Model equations - minor changes#627
smartie2076 merged 7 commits intoModel_equationsfrom
Model_equations_minor

Conversation

@smartie2076
Copy link
Copy Markdown
Collaborator

Fix #Issue

Changes proposed in this pull request:

  • Alignment of equations
  • Linebreaks
  • Descriptive sentences for equations

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@smartie2076
Copy link
Copy Markdown
Collaborator Author

@ursulaelmir I propose some small changes to your PR #581. Please let me know if you want to check what I did, otherwise I would merge this into your PR by the end of the week.

@smartie2076 smartie2076 mentioned this pull request Nov 4, 2020
10 tasks
@ursulaelmir
Copy link
Copy Markdown
Collaborator

@ursulaelmir I propose some small changes to your PR #581. Please let me know if you want to check what I did, otherwise I would merge this into your PR by the end of the week.

welcome back @smartie2076 :) I reviewed your changes and also proposed some minor ones as I read the readthedocs page

@smartie2076
Copy link
Copy Markdown
Collaborator Author

Thanks @ursulaelmir! I fixed your comments in the latest commit. Will merge it into your PR now.

@smartie2076 smartie2076 merged commit e706dc1 into Model_equations Nov 5, 2020
@smartie2076 smartie2076 deleted the Model_equations_minor branch November 5, 2020 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants