Skip to content

Add values of energy carrier weights #621

Merged
mahendrark merged 5 commits intodevfrom
fix/add_energy_carriers_to_constants
Oct 27, 2020
Merged

Add values of energy carrier weights #621
mahendrark merged 5 commits intodevfrom
fix/add_energy_carriers_to_constants

Conversation

@mahendrark
Copy link
Copy Markdown
Contributor

@mahendrark mahendrark commented Oct 27, 2020

Fix #616

Changes proposed in this pull request:

  • Your_changes

The following steps were realized, as well (if applies):

  • Use in-line comments to explain your code
  • Write docstrings to your code (example docstring)
  • For new functionalities: Explain in readthedocs
  • Write test(s) for your new patch of code (pytests, assertion debug messages)
  • Update the CHANGELOG.md
  • Apply black (black . --exclude docs/)
  • Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@mahendrark mahendrark self-assigned this Oct 27, 2020
@mahendrark mahendrark added the enhancement New feature or request label Oct 27, 2020
Copy link
Copy Markdown
Collaborator

@Bachibouzouk Bachibouzouk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the unit is correct, we can try to implement automatic csv generation from the python constant in a subsequent PR

@mahendrark mahendrark force-pushed the fix/add_energy_carriers_to_constants branch from 0c13912 to 75f5dd6 Compare October 27, 2020 15:30
@mahendrark mahendrark merged commit 6657c36 into dev Oct 27, 2020
@mahendrark mahendrark deleted the fix/add_energy_carriers_to_constants branch October 27, 2020 15:36
@smartie2076
Copy link
Copy Markdown
Collaborator

Ah, cool! Actually, I set myself a reminder with #628 but now it can be closed again, sorry about that xD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Documentation] Description of energy carrier weighting

3 participants