Improve the documentation section on assigning weights to the carriers#619
Merged
mahendrark merged 11 commits intodevfrom Oct 27, 2020
Merged
Improve the documentation section on assigning weights to the carriers#619mahendrark merged 11 commits intodevfrom
mahendrark merged 11 commits intodevfrom
Conversation
a46aa21 to
7c8a7be
Compare
Contributor
Author
|
I noticed several typos and fixed them in this file. Guess we have to do a review of the docs and see if there are any more typos |
Bachibouzouk
approved these changes
Oct 26, 2020
Collaborator
Bachibouzouk
left a comment
There was a problem hiding this comment.
The sentence "For most KPIs, including for example the share of renewables at the project location or its self-sufficiency, the baseline energy carrier used is of no relevance as the result is not dependent on it." could be improved a bit (split in two sentences?), otherwise I think it is good
Co-authored-by: Pierre Francois <[email protected]>
Co-authored-by: Pierre Francois <[email protected]>
4041996 to
fd821cc
Compare
9 tasks
5 tasks
Collaborator
|
Nice @mahendrark thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #616
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.