Conversation
|
#607 needs to be merged first |
b22c84d to
8d9d985
Compare
|
#607 is merged, is this ready to review then? There are some failing tests. |
Not yet, I have to update with latest dev, the only change we might keep is the MANIFEST.in file because to fix failing tests in #607, I already make some of the changes proposed in this PR. I will change it to a non-draft PR and tag you as a reviewer then :) |
8d9d985 to
470f371
Compare
470f371 to
e43bf0b
Compare
|
Remaining problem is In the wheel file "multi_vector_simulator-0.5.0rc7-py3-none-any.whl" downloaded from pypi.org those folders are there though (in "multi_vector_simulator-0.5.0rc7.data"... I am not sure why they are not accessible locally after pip install? They are also there in the "multi-vector-simulator-0.5.0rc7.tar.gz" on pypi |
be5e064 to
90ec18e
Compare
smartie2076
left a comment
There was a problem hiding this comment.
Is the feature to create an input template folder documented for the user in the RTD? Or is this not used for the end-user but something automated to be used for compiling the package data?
I have not tested this locally. Should I?
I can add something in the RTD for that (there is one thing which needs to be done to update the package_data folder before we upload to pypi which is documented in CONTRIBUTING, and there is something for the end user to create a copy of the input template in the local path which is not yet documented) |
f427107 to
5d86139
Compare
321a541 to
e59d8d2
Compare
The default folder should also be missing for the message to display Fix #614
e59d8d2 to
1a04930
Compare
Addresses #588, fix #614
Changes proposed in this pull request:
mvs_toolandmvs_reportinsetup.py(this can be simply typed directly in terminal)utils.copy_inputs_templateto copy input_template from package data_filesMANIFEST.infilemvs_create_input_templateinsetup.pyprepare_package.pyto add data to package and build dist folderContributing.mdTEMPLATE_INPUT_PATHand fielddata_filesfromsetup.pyTest locally
pip install multi-vector-simulator==0.5.0rc13, then make sure you are not in the mvs repo and runmvs_tool, it should create a folderMVS_outputMVS_outputpip install multi-vector-simulator==0.5.0rc13[report]and runmvs_tool -pdf, this should create a folderMVS_outputwith a subfolderreportin which the.pdfreport is located (styling of the report is partly fixed in Fix formatting and rendering issues in the autoreport #643)The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)For more information on how to contribute check the CONTRIBUTING.md.