Fix rtd for defining parameters as timeseries#597
Merged
smartie2076 merged 3 commits intodevfrom Oct 12, 2020
Merged
Conversation
SabineHaas
approved these changes
Oct 8, 2020
Contributor
SabineHaas
left a comment
There was a problem hiding this comment.
Nice!
You could check in readthedocs whether the links work well (activate branch) - or when it's merged to dev - to be sure.
Co-authored-by: Sabine Haas <[email protected]>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #595
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
❌ Use in-line comments to explain your code
❌ Write docstrings to your code (example docstring)
❌ For new functionalities: Explain in readthedocs
❌ Write test(s) for your new patch of code (pytests, assertion debug messages)
❌ Update the CHANGELOG.md
❌ Apply black (
black . --exclude docs/)❌ Check if benchmark tests pass locally (
EXECUTE_TESTS_ON=master pytest)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.