Skip to content

Fix rtd for defining parameters as timeseries#597

Merged
smartie2076 merged 3 commits intodevfrom
fix/rtd_formatting_error
Oct 12, 2020
Merged

Fix rtd for defining parameters as timeseries#597
smartie2076 merged 3 commits intodevfrom
fix/rtd_formatting_error

Conversation

@smartie2076
Copy link
Copy Markdown
Collaborator

Fix #595

Changes proposed in this pull request:

  • RTD entry for defining parameters as timeseries

The following steps were realized, as well (if applies):
❌ Use in-line comments to explain your code
❌ Write docstrings to your code (example docstring)
❌ For new functionalities: Explain in readthedocs
❌ Write test(s) for your new patch of code (pytests, assertion debug messages)
❌ Update the CHANGELOG.md
❌ Apply black (black . --exclude docs/)
❌ Check if benchmark tests pass locally (EXECUTE_TESTS_ON=master pytest)

Please mark above checkboxes as following:

  • Open
  • Done

❌ Check not applicable to this PR

For more information on how to contribute check the CONTRIBUTING.md.

@smartie2076 smartie2076 added the documentation Improvements or additions to documentation label Oct 8, 2020
@smartie2076 smartie2076 requested a review from SabineHaas October 8, 2020 10:05
@smartie2076 smartie2076 self-assigned this Oct 8, 2020
Copy link
Copy Markdown
Contributor

@SabineHaas SabineHaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
You could check in readthedocs whether the links work well (activate branch) - or when it's merged to dev - to be sure.

@smartie2076 smartie2076 merged commit 806c6dd into dev Oct 12, 2020
@smartie2076 smartie2076 deleted the fix/rtd_formatting_error branch November 5, 2020 17:41
@smartie2076 smartie2076 mentioned this pull request Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] How to provide a time dependent efficiency?

2 participants