Conversation
|
hi @smartie2076 , can we merge the new rst file so that I can see the updates on readthedocs? |
Sorry, we can not. You can either |
|
@ursulaelmir please message me directly / mail me when I should check this PR :) |
Hi @smartie2076 , to be honest I did not understand what you told me regarding how I can view the equations on readthedocs already |
Now you should be able to see the build of readthedocs in the checks (you need to push something to retrigger the build. You need to have a latex compiler installed locally in order to be able to see the equations on a local build. |
@Bachibouzouk I still can't see it on readthedocs. It's fine I will write all the equations then we see which ones don't show properly |
|
You can not see the equations because you did not add the file to the If you execute in the terminal: |
@smartie2076 that's why I wasn't getting it! |
Yeah, I was confused. Is it clear now? |
yes, thanks! |
|
hi @smartie2076 , I think the equations are now all included. maybe you can have a look at the example components and abbreviations used and so on and let me know if anything needs to be changed or added. otherwise I would mark this as ready for review :) |
|
Hi @ursulaelmir! I am on vacation currently, so I can't review the PR. I will check it first thing after my return. |
|
I like what you did and proposed some small changes in #627. Can you post the file you used for the image here, so that we can change it later if necessary? |
|
After merging #627, this one is ready to merge! Yay! |
the file type is not supported (.drawio). i can send it to you by email |
You can compess it in a |
This PR does not change any code, so it can be merged into the next PR.
|
Congratiulations @ursulaelmir! Your last PR is merged. Thank you for the effort you put into it after the official end :) |
|
@smartie2076 here you go :) |
Fix #574
Changes proposed in this pull request:
The following steps were realized, as well (if applies):
black . --exclude docs/)EXECUTE_TESTS_ON=master pytest)Please mark above checkboxes as following:
❌ Check not applicable to this PR
For more information on how to contribute check the CONTRIBUTING.md.